gortiz commented on code in PR #15848:
URL: https://github.com/apache/pinot/pull/15848#discussion_r2102462802
##########
pinot-query-runtime/src/test/resources/queries/NullHandling.json:
##########
@@ -64,6 +64,26 @@
"description": "LEFT JOIN and GROUP BY with AGGREGATE AND SORT",
"sql": "SELECT {tbl1}.strCol2, COUNT({tbl2}.intCol1),
MIN({tbl2}.intCol1) AS minCol, MAX({tbl2}.doubleCol1) AS maxCol,
SUM({tbl2}.doubleCol1) FROM {tbl1} LEFT OUTER JOIN {tbl2} ON {tbl1}.strCol1 =
{tbl2}.strCol1 GROUP BY {tbl1}.strCol2 ORDER BY minCol DESC NULLS LAST, maxCol
ASC NULLS LAST",
"keepOutputRowOrder": true
+ },
+ {
+ "description": "Joining with nullable int column",
+ "sql": "SET enableNullHandling = TRUE;\nWITH tableWithNull AS (\n
SELECT cast(intCol1 as INT) col1,\n CASE\n WHEN intCol1
> 0 THEN NULL\n ELSE cast(intCol1 as INT)\n END AS
nullableCol1\n FROM {tbl1}\n)\nSELECT t1.col1\nFROM tableWithNull as
t1\nJOIN tableWithNull as t2\nON t1.col1 = t2.nullableCol1",
Review Comment:
Done. I've still kept the next line indented so h2 and pinot queries match
vertically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
