Jackie-Jiang commented on code in PR #15869:
URL: https://github.com/apache/pinot/pull/15869#discussion_r2103593149
##########
pinot-core/src/main/java/org/apache/pinot/core/query/executor/SingleTableExecutionInfo.java:
##########
@@ -151,18 +152,18 @@ private SingleTableExecutionInfo(TableDataManager
tableDataManager, List<Segment
_notAcquiredSegments = notAcquiredSegments;
}
- @Override
- public boolean hasRealtime() {
- return _tableDataManager instanceof RealtimeTableDataManager;
- }
-
-
public TableDataManager getTableDataManager() {
return _tableDataManager;
}
- public List<SegmentDataManager> getSegmentDataManagers() {
- return _segmentDataManagers;
+ @Override
+ public Schema getSchema() {
+ return _tableDataManager.getCachedTableConfigAndSchema().getRight();
Review Comment:
This schema is cached for query purpose, and is already used by MSE leaf
stage query optimization. If we need absolute latest schema, we can send a
Helix message to refresh it. It is out of the scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
