Jackie-Jiang commented on code in PR #15870:
URL: https://github.com/apache/pinot/pull/15870#discussion_r2103599233
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -559,8 +559,9 @@ public ServerReloadControllerJobStatusResponse
getReloadJobStatus(
+
controllerJobZKMetadata.get(CommonConstants.ControllerJob.SUBMISSION_TIME_MS);
if (segmentNames != null) {
List<String> targetSegments = serverToSegments.get(server);
- reloadTaskStatusEndpoint = reloadTaskStatusEndpoint + "&segmentName="
+ StringUtils.join(targetSegments,
- SegmentNameUtils.SEGMENT_NAME_SEPARATOR);
+ List<String> encodedTargetSegments =
targetSegments.stream().map(URIUtils::encode).collect(Collectors.toList());
Review Comment:
(minor) Consider looping over `targetSegments` and manually construct the
string to avoid extra memory overhead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
