anandheritage commented on PR #15844: URL: https://github.com/apache/pinot/pull/15844#issuecomment-2901716376
> It'll be good if you can share some perf number comparing this new `IndexedTable` with the existing one Benchmark Mode Cnt Score Error Units BenchmarkDeterministicIndexedTable.concurrentIndexedTable avgt 3 10394.142 ± 3703.863 us/op BenchmarkDeterministicIndexedTable.deterministicIndexedTable avgt 3 12908.535 ± 5678.687 us/op BenchmarkDeterministicIndexedTable.simpleIndexedTable avgt 3 8966.736 ± 1420.956 us/op Although this IndexTable is going to get triggered specifically using the option defined. The performace compared to concurrentIndexTable will be worse because the get , add and remove are log(N) ops. N - Value of the limit. These benchmarks are from my local machine - Will check if CI/CD also runs the benchmarks that will be more accurate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
