(pinot) branch master updated: Fix internal logic of pre-check minimizeDataMovement (#15527)

2025-04-11 Thread xbli
This is an automated email from the ASF dual-hosted git repository. xbli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 79da40671c Fix internal logic of pre-check minimize

Re: [PR] Fix internal logic of pre-check minimizeDataMovement [pinot]

2025-04-11 Thread via GitHub
klsince merged PR #15527: URL: https://github.com/apache/pinot/pull/15527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

Re: [PR] Fix and clean-up upsert and dedup config [pinot]

2025-04-11 Thread via GitHub
codecov-commenter commented on PR #15528: URL: https://github.com/apache/pinot/pull/15528#issuecomment-2798304956 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15528?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch master updated: Add tests to clarify the limits of base64 encoded string detector. (#15497)

2025-04-11 Thread tingchen
This is an automated email from the ASF dual-hosted git repository. tingchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 441a2df742 Add tests to clarify the limits of b

Re: [PR] Add tests to clarify the limits of base64 encoded string detector. [pinot]

2025-04-11 Thread via GitHub
chenboat merged PR #15497: URL: https://github.com/apache/pinot/pull/15497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[PR] Fix and clean-up upsert and dedup config [pinot]

2025-04-11 Thread via GitHub
Jackie-Jiang opened a new pull request, #15528: URL: https://github.com/apache/pinot/pull/15528 Bugfixes: - Introduce `Enablement` enum with value `ENABLE`, `DISABLE` and `DEFAULT` to control the enablement of a feature. For `DEFAULT` enablement, use the default config from upper level (

Re: [PR] Fix internal logic of pre-check minimizeDataMovement [pinot]

2025-04-11 Thread via GitHub
codecov-commenter commented on PR #15527: URL: https://github.com/apache/pinot/pull/15527#issuecomment-2798171562 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15527?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch master updated: Expose more parameters in rebalance config via controller config (#15509)

2025-04-11 Thread xbli
This is an automated email from the ASF dual-hosted git repository. xbli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 6c0215834b Expose more parameters in rebalance conf

Re: [PR] Expose more parameters in rebalance config via controller config [pinot]

2025-04-11 Thread via GitHub
klsince merged PR #15509: URL: https://github.com/apache/pinot/pull/15509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

Re: [PR] Expose more parameters in rebalance config via controller config [pinot]

2025-04-11 Thread via GitHub
klsince commented on code in PR #15509: URL: https://github.com/apache/pinot/pull/15509#discussion_r2040387004 ## pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java: ## @@ -198,6 +198,11 @@ public static class ControllerPeriodicTasksConf { "c

Re: [PR] [Issue 12676 - Part 2.1] Adding com.google.api.grpc:proto-google-common-protos [pinot]

2025-04-11 Thread via GitHub
leujean02 closed pull request #15500: [Issue 12676 - Part 2.1] Adding com.google.api.grpc:proto-google-common-protos URL: https://github.com/apache/pinot/pull/15500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Fix internal logic of pre-check minimizeDataMovement [pinot]

2025-04-11 Thread via GitHub
somandal commented on code in PR #15527: URL: https://github.com/apache/pinot/pull/15527#discussion_r2040352447 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java: ## @@ -227,9 +228,31 @@ private RebalancePreChecker

Re: [PR] Map encoded forward index support [pinot]

2025-04-11 Thread via GitHub
codecov-commenter commented on PR #15526: URL: https://github.com/apache/pinot/pull/15526#issuecomment-2798090557 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15526?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Fix internal logic of pre-check minimizeDataMovement [pinot]

2025-04-11 Thread via GitHub
J-HowHuang opened a new pull request, #15527: URL: https://github.com/apache/pinot/pull/15527 ## Description For table config: ``` ... "instanceAssignmentConfigMap": { "CONSUMING": { "tagPoolConfig": { "tag": "DefaultTenant_OFFLINE",

[PR] Map encoded forward index support [pinot]

2025-04-11 Thread via GitHub
raghavyadav01 opened a new pull request, #15526: URL: https://github.com/apache/pinot/pull/15526 Changes to Enable Pluggable forward Index and Map Index Filter Operator ## Overview This PR introduces support for pluggable forward index readers and add MapIndexFilteroperator for MA

Re: [PR] support to enable Map encoded custom forward index [pinot]

2025-04-11 Thread via GitHub
raghavyadav01 closed pull request #15006: support to enable Map encoded custom forward index URL: https://github.com/apache/pinot/pull/15006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Table Rebalance Logger [pinot]

2025-04-11 Thread via GitHub
somandal commented on code in PR #15436: URL: https://github.com/apache/pinot/pull/15436#discussion_r2040178105 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java: ## @@ -74,16 +74,17 @@ public Map check(PreCheckCo

Re: [PR] Table Rebalance Logger [pinot]

2025-04-11 Thread via GitHub
J-HowHuang commented on code in PR #15436: URL: https://github.com/apache/pinot/pull/15436#discussion_r2040164400 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java: ## @@ -74,16 +74,17 @@ public Map check(PreCheck

Re: [PR] Table Rebalance Logger [pinot]

2025-04-11 Thread via GitHub
Jackie-Jiang commented on code in PR #15436: URL: https://github.com/apache/pinot/pull/15436#discussion_r2040138757 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java: ## @@ -74,16 +74,17 @@ public Map check(PreChe

Re: [PR] Table Rebalance Logger [pinot]

2025-04-11 Thread via GitHub
J-HowHuang commented on code in PR #15436: URL: https://github.com/apache/pinot/pull/15436#discussion_r2040146229 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java: ## @@ -74,16 +74,17 @@ public Map check(PreCheck

Re: [PR] Table Rebalance Logger [pinot]

2025-04-11 Thread via GitHub
J-HowHuang commented on code in PR #15436: URL: https://github.com/apache/pinot/pull/15436#discussion_r2040146229 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java: ## @@ -74,16 +74,17 @@ public Map check(PreCheck

Re: [PR] Table Rebalance Logger [pinot]

2025-04-11 Thread via GitHub
Jackie-Jiang commented on code in PR #15436: URL: https://github.com/apache/pinot/pull/15436#discussion_r2040141502 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java: ## @@ -74,16 +74,17 @@ public Map check(PreChe

Re: [PR] [Canary Routing] pass in the preferred replica group option to change the routing strategy for canary queries [pinot]

2025-04-11 Thread via GitHub
wirybeaver commented on code in PR #15203: URL: https://github.com/apache/pinot/pull/15203#discussion_r2037942177 ## pinot-core/src/main/java/org/apache/pinot/core/transport/ServerInstance.java: ## @@ -173,4 +189,18 @@ public int hashCode() { public String toString() { r

Re: [PR] [Canary Routing] pass in the preferred replica group option to change the routing strategy for canary queries [pinot]

2025-04-11 Thread via GitHub
wirybeaver commented on code in PR #15203: URL: https://github.com/apache/pinot/pull/15203#discussion_r2040096088 ## pinot-core/src/main/java/org/apache/pinot/core/transport/ServerInstance.java: ## @@ -91,6 +102,7 @@ public ServerInstance(InstanceConfig instanceConfig) { _q

Re: [PR] Metrics that Tracks the Progress of each Table Rebalance Job [pinot]

2025-04-11 Thread via GitHub
somandal commented on code in PR #15518: URL: https://github.com/apache/pinot/pull/15518#discussion_r2040003958 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/ZkBasedTableRebalanceObserver.java: ## @@ -122,6 +125,7 @@ public void onTrigger(Tri

Re: [PR] Add null handling support for MV aggregation functions - COUNT, MIN, MAX, SUM, AVG, MINMAXRANGE [pinot]

2025-04-11 Thread via GitHub
codecov-commenter commented on PR #15524: URL: https://github.com/apache/pinot/pull/15524#issuecomment-2796991493 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15524?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Metrics that Tracks the Progress of each Table Rebalance Job [pinot]

2025-04-11 Thread via GitHub
somandal commented on code in PR #15518: URL: https://github.com/apache/pinot/pull/15518#discussion_r2040004992 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/ZkBasedTableRebalanceObserver.java: ## @@ -205,6 +209,17 @@ public int getNumUpdates

Re: [PR] Metrics that Tracks the Progress of each Table Rebalance Job [pinot]

2025-04-11 Thread via GitHub
somandal commented on code in PR #15518: URL: https://github.com/apache/pinot/pull/15518#discussion_r2040003958 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/ZkBasedTableRebalanceObserver.java: ## @@ -122,6 +125,7 @@ public void onTrigger(Tri

Re: [PR] Metrics that Tracks the Progress of each Table Rebalance Job [pinot]

2025-04-11 Thread via GitHub
somandal commented on code in PR #15518: URL: https://github.com/apache/pinot/pull/15518#discussion_r204826 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java: ## @@ -205,7 +205,11 @@ public enum ControllerGauge implements AbstractMetrics.Gau

Re: [PR] Expose more parameters in rebalance config via controller config [pinot]

2025-04-11 Thread via GitHub
J-HowHuang commented on code in PR #15509: URL: https://github.com/apache/pinot/pull/15509#discussion_r2039977670 ## pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java: ## @@ -198,6 +198,11 @@ public static class ControllerPeriodicTasksConf {

Re: [PR] Metrics that Tracks the Number of Table Rebalance Job In Progress [pinot]

2025-04-11 Thread via GitHub
somandal commented on code in PR #15517: URL: https://github.com/apache/pinot/pull/15517#discussion_r2039978597 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -140,6 +142,7 @@ public class TableRebalancer { // TO

Re: [PR] [Canary Routing] pass in the preferred replica group option to change the routing strategy for canary queries [pinot]

2025-04-11 Thread via GitHub
chenboat commented on code in PR #15203: URL: https://github.com/apache/pinot/pull/15203#discussion_r2032112990 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/adaptiveserverselector/ServerSelectionContext.java: ## @@ -0,0 +1,43 @@ +/** + * Licensed to the Apache S

Re: [PR] [Canary Routing] pass in the preferred replica group option to change the routing strategy for canary queries [pinot]

2025-04-11 Thread via GitHub
ankitsultana commented on code in PR #15203: URL: https://github.com/apache/pinot/pull/15203#discussion_r2039954815 ## pinot-core/src/main/java/org/apache/pinot/core/transport/ServerInstance.java: ## @@ -91,6 +102,7 @@ public ServerInstance(InstanceConfig instanceConfig) {

Re: [PR] Expose more parameters in rebalance config via controller config [pinot]

2025-04-11 Thread via GitHub
klsince commented on code in PR #15509: URL: https://github.com/apache/pinot/pull/15509#discussion_r2039950915 ## pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java: ## @@ -198,6 +198,11 @@ public static class ControllerPeriodicTasksConf { "c

Re: [PR] Metrics that Tracks the Number of Table Rebalance Job In Progress [pinot]

2025-04-11 Thread via GitHub
J-HowHuang commented on code in PR #15517: URL: https://github.com/apache/pinot/pull/15517#discussion_r2039934164 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -431,6 +432,10 @@ private RebalanceResult doRebalance(

Re: [PR] Metrics that Tracks the Number of Table Rebalance Job In Progress [pinot]

2025-04-11 Thread via GitHub
somandal commented on code in PR #15517: URL: https://github.com/apache/pinot/pull/15517#discussion_r2039903191 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -431,6 +432,10 @@ private RebalanceResult doRebalance(Ta

Re: [PR] Extract Table Processing Code in ServerExecutorV1Impl to TableExecutionInfo class [pinot]

2025-04-11 Thread via GitHub
codecov-commenter commented on PR #15523: URL: https://github.com/apache/pinot/pull/15523#issuecomment-2796933506 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15523?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Metrics that Tracks the Number of Table Rebalance Job In Progress [pinot]

2025-04-11 Thread via GitHub
J-HowHuang commented on code in PR #15517: URL: https://github.com/apache/pinot/pull/15517#discussion_r2039838035 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -431,6 +432,10 @@ private RebalanceResult doRebalance(

Re: [PR] Metrics that Tracks the Number of Table Rebalance Job In Progress [pinot]

2025-04-11 Thread via GitHub
somandal commented on code in PR #15517: URL: https://github.com/apache/pinot/pull/15517#discussion_r2039663820 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -431,6 +432,10 @@ private RebalanceResult doRebalance(Ta

Re: [PR] Fix MIN_MAX_RANGE aggregation function behavior when all input values are null [pinot]

2025-04-11 Thread via GitHub
codecov-commenter commented on PR #15525: URL: https://github.com/apache/pinot/pull/15525#issuecomment-2797000761 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15525?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Add null handling support for MV aggregation functions - COUNT, MIN, MAX, SUM, AVG, MINMAXRANGE [pinot]

2025-04-11 Thread via GitHub
yashmayya opened a new pull request, #15524: URL: https://github.com/apache/pinot/pull/15524 - This patch adds null handling support for the most common MV aggregation functions - COUNT, MIN, MAX, SUM, AVG, MINMAXRANGE. - It follows the same principles as in https://github.com/apache/pin

[PR] Extract Table Processing Code in ServerExecutorV1Impl to TableExecutionInfo class [pinot]

2025-04-11 Thread via GitHub
vrajat opened a new pull request, #15523: URL: https://github.com/apache/pinot/pull/15523 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat` 6.

Re: [PR] Bump org.apache.commons:commons-text from 1.13.0 to 1.13.1 [pinot]

2025-04-11 Thread via GitHub
codecov-commenter commented on PR #15521: URL: https://github.com/apache/pinot/pull/15521#issuecomment-2796681703 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15521?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.19 to 2.31.20 [pinot]

2025-04-11 Thread via GitHub
codecov-commenter commented on PR #15520: URL: https://github.com/apache/pinot/pull/15520#issuecomment-2796681683 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15520?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.31.20 created (now a14a8c31bd)

2025-04-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.31.20 in repository https://gitbox.apache.org/repos/asf/pinot.git at a14a8c31bd Bump software.amazon.awssdk:bom from 2.31.19 to 2.31.20 N

[PR] Bump org.apache.commons:commons-text from 1.13.0 to 1.13.1 [pinot]

2025-04-11 Thread via GitHub
dependabot[bot] opened a new pull request, #15521: URL: https://github.com/apache/pinot/pull/15521 Bumps org.apache.commons:commons-text from 1.13.0 to 1.13.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org

(pinot) branch dependabot/maven/org.apache.commons-commons-text-1.13.1 created (now 30a404bc44)

2025-04-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.commons-commons-text-1.13.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at 30a404bc44 Bump org.apache.commons:commons-text from 1.13.0 to 1.

[PR] Bump software.amazon.awssdk:bom from 2.31.19 to 2.31.20 [pinot]

2025-04-11 Thread via GitHub
dependabot[bot] opened a new pull request, #15520: URL: https://github.com/apache/pinot/pull/15520 Bumps software.amazon.awssdk:bom from 2.31.19 to 2.31.20. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- |

Re: [PR] Logical table CRUD operations. [pinot]

2025-04-11 Thread via GitHub
abhishekbafna commented on code in PR #15515: URL: https://github.com/apache/pinot/pull/15515#discussion_r2039159582 ## pinot-common/src/main/java/org/apache/pinot/common/utils/LogicalTableUtils.java: ## @@ -0,0 +1,52 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

(pinot) branch master updated: [bugfix][ui] Fixes for table rebalance UI (#15511)

2025-04-11 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 196de1d54f [bugfix][ui] Fixes for table rebala

Re: [PR] [bugfix][ui] Fixes for table rebalance UI [pinot]

2025-04-11 Thread via GitHub
yashmayya merged PR #15511: URL: https://github.com/apache/pinot/pull/15511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [PR] Logical table CRUD operations. [pinot]

2025-04-11 Thread via GitHub
abhishekbafna commented on code in PR #15515: URL: https://github.com/apache/pinot/pull/15515#discussion_r2038951541 ## pinot-common/src/main/java/org/apache/pinot/common/utils/LogicalTableUtils.java: ## @@ -0,0 +1,52 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Logical table CRUD operations. [pinot]

2025-04-11 Thread via GitHub
abhishekbafna commented on code in PR #15515: URL: https://github.com/apache/pinot/pull/15515#discussion_r2038923205 ## pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java: ## @@ -376,6 +385,7 @@ public static boolean removeSegmentZKMetadata(ZkHe