somandal commented on code in PR #15517:
URL: https://github.com/apache/pinot/pull/15517#discussion_r2039978597
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -140,6 +142,7 @@ public class TableRebalancer {
// TODO: Consider making the timeoutMs below table rebalancer configurable
private static final int TABLE_SIZE_READER_TIMEOUT_MS = 30_000;
private static final int STREAM_PARTITION_OFFSET_READ_TIMEOUT_MS = 10_000;
+ private static final AtomicInteger _rebalanceJobCounter = new
AtomicInteger(0);
Review Comment:
could you add a test in one of the integration tests to validate that this
increments across all table rebalance objects? (you can just validate the gauge
value -> check that if you create two table rebalance objects and call
rebalance method then this is incremented by 2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
