J-HowHuang commented on code in PR #15517:
URL: https://github.com/apache/pinot/pull/15517#discussion_r2039934164
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -431,6 +432,10 @@ private RebalanceResult doRebalance(TableConfig
tableConfig, RebalanceConfig reb
estimatedAverageSegmentSizeInBytes, allSegmentsFromIdealState,
segmentsToMonitor);
// Record the beginning of rebalance
+ // We emit this metric only when the rebalance does get to this code path,
i.e. excluding dry-run and downtime
+ if (_controllerMetrics != null) {
Review Comment:
That makes sense with my understanding with that. I switched out to using a
gauge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
