somandal commented on code in PR #15518:
URL: https://github.com/apache/pinot/pull/15518#discussion_r2040003958
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/ZkBasedTableRebalanceObserver.java:
##########
@@ -122,6 +125,7 @@ public void onTrigger(Trigger trigger, Map<String,
Map<String, String>> currentS
Trigger.NEXT_ASSINGMENT_CALCULATION_TRIGGER,
_tableRebalanceProgressStats);
if
(!_tableRebalanceProgressStats.getRebalanceProgressStatsCurrentStep().equals(latestProgress))
{
_tableRebalanceProgressStats.setRebalanceProgressStatsCurrentStep(latestProgress);
+ emitProgressMetric(latestProgress);
Review Comment:
`latestProgress` is on the Step level stats. You should fetch the overall
stats instead (or skip emitting from here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
