J-HowHuang commented on code in PR #15436:
URL: https://github.com/apache/pinot/pull/15436#discussion_r2040164400
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##########
@@ -74,16 +74,17 @@ public Map<String, RebalancePreCheckerResult>
check(PreCheckContext preCheckCont
String tableNameWithType = preCheckContext.getTableNameWithType();
TableConfig tableConfig = preCheckContext.getTableConfig();
RebalanceConfig rebalanceConfig = preCheckContext.getRebalanceConfig();
+ Logger tableRebalanceLogger = LoggerFactory.getLogger(LOGGER.getName() +
"_" + rebalanceJobId);
Review Comment:
> If we want to unify the logger for these 2 classes, we may also name the
logger Rebalance-<tableNameWithType>-<jobId>
I think it's okay to keep them separate. @somandal any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
