ankitsultana commented on code in PR #15203:
URL: https://github.com/apache/pinot/pull/15203#discussion_r2039954815
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/ServerInstance.java:
##########
@@ -91,6 +102,7 @@ public ServerInstance(InstanceConfig instanceConfig) {
_queryServicePort = INVALID_PORT;
_queryMailboxPort = INVALID_PORT;
_adminEndpoint = null;
+ _group = DEFAULT_SERVER_REPLICA_GROUP_OF_BROKER_VIEW;
Review Comment:
From a semantic point of view a ServerInstance does not have any
replica-group concept. Replica-groups are defined at a table level and a given
server may belong to different replica-groups for different tables.
Can you think about what this value represents exactly? We can name it
accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
