J-HowHuang commented on code in PR #15436:
URL: https://github.com/apache/pinot/pull/15436#discussion_r2040146229
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##########
@@ -74,16 +74,17 @@ public Map<String, RebalancePreCheckerResult>
check(PreCheckContext preCheckCont
String tableNameWithType = preCheckContext.getTableNameWithType();
TableConfig tableConfig = preCheckContext.getTableConfig();
RebalanceConfig rebalanceConfig = preCheckContext.getRebalanceConfig();
+ Logger tableRebalanceLogger = LoggerFactory.getLogger(LOGGER.getName() +
"_" + rebalanceJobId);
Review Comment:
~The job IDs are using hyphen `-` (e.g.
`e131072c-a37a-4e06-8d11-e27b40004788`), would it be better to separate class
name and job ID with an underscore `_`?~
tableNameWithType has an underscore. I think the name you suggested might be
better to regex etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
