gortiz commented on code in PR #15387:
URL: https://github.com/apache/pinot/pull/15387#discussion_r2018026339
##
pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMetrics.java:
##
@@ -84,4 +91,23 @@ protected BrokerMeter[] getMeters() {
protected BrokerGauge[]
gortiz commented on code in PR #15387:
URL: https://github.com/apache/pinot/pull/15387#discussion_r2018025039
##
pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java:
##
@@ -18,195 +18,134 @@
*/
package org.apache.pinot.common.metrics;
+import java.ut
Jackie-Jiang commented on PR #15063:
URL: https://github.com/apache/pinot/pull/15063#issuecomment-2742011864
Hold on this PR to debug why Helix behavior changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
krishan1390 commented on code in PR #15387:
URL: https://github.com/apache/pinot/pull/15387#discussion_r2017933728
##
pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMetrics.java:
##
@@ -84,4 +91,23 @@ protected BrokerMeter[] getMeters() {
protected BrokerGau
codecov-commenter commented on PR #15393:
URL: https://github.com/apache/pinot/pull/15393#issuecomment-2760254138
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15393?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
codecov-commenter commented on PR #15384:
URL: https://github.com/apache/pinot/pull/15384#issuecomment-2760262073
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15384?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
krishan1390 commented on code in PR #15387:
URL: https://github.com/apache/pinot/pull/15387#discussion_r2017949534
##
pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java:
##
@@ -18,195 +18,134 @@
*/
package org.apache.pinot.common.metrics;
+import ja
vrajat commented on code in PR #15387:
URL: https://github.com/apache/pinot/pull/15387#discussion_r2017945811
##
pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java:
##
@@ -18,195 +18,134 @@
*/
package org.apache.pinot.common.metrics;
+import java.ut
xiangfu0 opened a new pull request, #15393:
URL: https://github.com/apache/pinot/pull/15393
We observed certain failure due to the same client id:
```
javax.management.InstanceAlreadyExistsException:
kafka.consumer:type=app-info,id=PartitionGroupMetadataFetcher-_REALTIME-
at
engrravijain commented on issue #15311:
URL: https://github.com/apache/pinot/issues/15311#issuecomment-2760205346
@xiangfu0 I would like to pick this up! Please assign this to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
krishan1390 commented on code in PR #15387:
URL: https://github.com/apache/pinot/pull/15387#discussion_r2017926330
##
pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java:
##
@@ -18,195 +18,134 @@
*/
package org.apache.pinot.common.metrics;
+import ja
krishan1390 commented on code in PR #15387:
URL: https://github.com/apache/pinot/pull/15387#discussion_r2017897838
##
pinot-broker/src/main/java/org/apache/pinot/broker/grpc/BrokerGrpcServer.java:
##
@@ -181,15 +182,17 @@ public void submit(Broker.BrokerRequest request,
try
krishan1390 commented on code in PR #15387:
URL: https://github.com/apache/pinot/pull/15387#discussion_r2017899865
##
pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java:
##
@@ -18,195 +18,134 @@
*/
package org.apache.pinot.common.metrics;
+import ja
mghildiy commented on code in PR #15377:
URL: https://github.com/apache/pinot/pull/15377#discussion_r2017855306
##
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/RoundDecimalTransformFunction.java:
##
@@ -90,8 +90,12 @@ public double[] transformToDoub
codecov-commenter commented on PR #15392:
URL: https://github.com/apache/pinot/pull/15392#issuecomment-2759959602
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15392?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
KKcorps commented on code in PR #15383:
URL: https://github.com/apache/pinot/pull/15383#discussion_r2017823711
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##
@@ -2425,10 +2427,22 @@ public void
repairSeg
lnbest0707-uber commented on PR #15390:
URL: https://github.com/apache/pinot/pull/15390#issuecomment-2759919520
LGTM, can we also update the PR description? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
Jackie-Jiang closed pull request #15141: Upgrade Calcite to 1.38.0
URL: https://github.com/apache/pinot/pull/15141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
ankitsultana commented on issue #15306:
URL: https://github.com/apache/pinot/issues/15306#issuecomment-2759963904
Yeah we are planning to pick this up in a week or two. Will add more details
to the description.
--
This is an automated message from the Apache Git Service.
To respond to the
Jackie-Jiang commented on issue #15306:
URL: https://github.com/apache/pinot/issues/15306#issuecomment-2759957931
We'll need more context to debug this, especially the query and column data
type
--
This is an automated message from the Apache Git Service.
To respond to the message, please
somandal commented on PR #15360:
URL: https://github.com/apache/pinot/pull/15360#issuecomment-2759931070
@klsince just a note that I keep hitting integration test failures due to
flaky tests. I run them locally and they pass
--
This is an automated message from the Apache Git Service.
To
codecov-commenter commented on PR #15391:
URL: https://github.com/apache/pinot/pull/15391#issuecomment-2759927053
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15391?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
somandal commented on PR #15392:
URL: https://github.com/apache/pinot/pull/15392#issuecomment-2759922327
cc @Jackie-Jiang @klsince @npawar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
somandal opened a new pull request, #15392:
URL: https://github.com/apache/pinot/pull/15392
Add metrics to track segment operation throttle thresholds and count of
number of segments undergoing the given operation.
Testing done:
- Added tests in `SegmentOperationsThrottlerTest`
-
codecov-commenter commented on PR #15390:
URL: https://github.com/apache/pinot/pull/15390#issuecomment-2759904489
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15390?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
Jackie-Jiang opened a new pull request, #15391:
URL: https://github.com/apache/pinot/pull/15391
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
codecov-commenter commented on PR #15389:
URL: https://github.com/apache/pinot/pull/15389#issuecomment-2759871642
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15389?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
chenboat opened a new pull request, #15390:
URL: https://github.com/apache/pinot/pull/15390
Instructions:
1. The PR has to be tagged with at least one of the following labels (*):
1. `feature`
2. `bugfix`
3. `performance`
4. `ui`
5. `backward-incompat`
6
J-HowHuang opened a new pull request, #15389:
URL: https://github.com/apache/pinot/pull/15389
## Description
In #15232 some default value of the table rebalance API was set to false,
which makes this URL builder fail to construct the request that yields the
expected table rebalance b
somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2017709368
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/ControllerRequestURLBuilder.java:
##
@@ -214,7 +214,7 @@ public String forTableRebalance(String tableName
rhodo commented on PR #15345:
URL: https://github.com/apache/pinot/pull/15345#issuecomment-2759774679
> @rhodo I understand this PR has already been merged but would like to
understand following
>
> 1. What is the rationale of adding this metric. Where would we need this ?
> 2. The
somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2017708428
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -733,15 +781,148 @@ private RebalanceSummaryResult
calc
J-HowHuang commented on code in PR #15284:
URL: https://github.com/apache/pinot/pull/15284#discussion_r2017706583
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -662,6 +663,20 @@ private RebalanceSummaryResult
calc
somandal commented on PR #15360:
URL: https://github.com/apache/pinot/pull/15360#issuecomment-2759463641
another test failure that is unrelated and passes locally:
```
Error: Failures:
Error:
RealtimeToOfflineSegmentsMinionClusterIntegrationTest.setUp:101->ClusterTest.start
Jackie-Jiang commented on PR #15263:
URL: https://github.com/apache/pinot/pull/15263#issuecomment-2759587140
Per
[PostgreSQL](https://www.postgresql.org/docs/current/datatype-numeric.html):
```
The maximum precision that can be explicitly specified in a numeric type
declaration is 100
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2017641431
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -625,22 +651,35 @@ private RebalanceSummaryResult
cal
Jackie-Jiang commented on PR #15063:
URL: https://github.com/apache/pinot/pull/15063#issuecomment-2759576371
Filed a Helix issue: https://github.com/apache/helix/issues/3014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2017644393
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/ControllerRequestURLBuilder.java:
##
@@ -214,7 +214,7 @@ public String forTableRebalance(String tableNa
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2017652432
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -733,15 +781,148 @@ private RebalanceSummaryResult
ca
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2017645770
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -733,15 +781,148 @@ private RebalanceSummaryResult
ca
This is an automated email from the ASF dual-hosted git repository.
xbli pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 772eaea17e Revert the null value handling when nullHandlingEnabled is
false (#15382)
add 9090972452 Precheck Rebala
klsince merged PR #15317:
URL: https://github.com/apache/pinot/pull/15317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
Jackie-Jiang commented on code in PR #14941:
URL: https://github.com/apache/pinot/pull/14941#discussion_r2017624085
##
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/funnel/window/FunnelEventsFunctionEvalAggregationFunction.java:
##
@@ -0,0 +1,502 @@
+
xiangfu0 commented on issue #15306:
URL: https://github.com/apache/pinot/issues/15306#issuecomment-2759493642
Can we reproduce this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2017439035
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java:
##
@@ -240,6 +240,92 @@ public Map
getServerSegmentCha
Jackie-Jiang commented on issue #15378:
URL: https://github.com/apache/pinot/issues/15378#issuecomment-2759364209
cc @KKcorps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
Jackie-Jiang commented on code in PR #15284:
URL: https://github.com/apache/pinot/pull/15284#discussion_r2017529361
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -662,6 +663,20 @@ private RebalanceSummaryResult
ca
somandal commented on PR #15360:
URL: https://github.com/apache/pinot/pull/15360#issuecomment-2759343072
test failure seems to be unrelated to my changes:
```
Error: Failures:
Error:
MultiStageEngineIntegrationTest.testGeneratedQueries:214->BaseClusterIntegrationTestSet.tes
Jackie-Jiang closed issue #13482: Unit test failure in QueryRoutingTest
URL: https://github.com/apache/pinot/issues/13482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch hotfix-array-agg
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/hotfix-array-agg by this push:
new 49c90d4030 Revert the null valu
krishan1390 commented on PR #15387:
URL: https://github.com/apache/pinot/pull/15387#issuecomment-2757934668
> `BrokerRequestHandlers` is a better place to capture these metrics. Many
other metrics are reported there as well.
>
>
https://github.com/apache/pinot/blob/master/pinot-broke
Jackie-Jiang commented on issue #13482:
URL: https://github.com/apache/pinot/issues/13482#issuecomment-2759148405
I haven't seen any failure on this test recently, and this part of the code
has been modified multiple times since the issue is opened. I'd close it for
now, and we can revisit
Jackie-Jiang commented on code in PR #15359:
URL: https://github.com/apache/pinot/pull/15359#discussion_r2017452641
##
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/EnrichmentConfig.java:
##
@@ -32,13 +32,21 @@ public class EnrichmentConfig extends BaseJson
J-HowHuang commented on code in PR #15317:
URL: https://github.com/apache/pinot/pull/15317#discussion_r2017455457
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -279,6 +299,43 @@ private RebalancePreCheck
Jackie-Jiang commented on code in PR #15358:
URL: https://github.com/apache/pinot/pull/15358#discussion_r2017443281
##
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##
@@ -72,6 +72,10 @@ public class ControllerConf extends PinotConfiguration {
Jackie-Jiang commented on code in PR #15349:
URL: https://github.com/apache/pinot/pull/15349#discussion_r2017436039
##
pinot-core/src/main/java/org/apache/pinot/core/geospatial/transform/function/GridDiskFunction.java:
##
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software
Jackie-Jiang commented on code in PR #15349:
URL: https://github.com/apache/pinot/pull/15349#discussion_r2017434665
##
pinot-core/src/main/java/org/apache/pinot/core/geospatial/transform/function/ScalarFunctions.java:
##
@@ -267,4 +268,18 @@ public static long gridDistance(long
J-HowHuang commented on code in PR #15284:
URL: https://github.com/apache/pinot/pull/15284#discussion_r2017425633
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java:
##
@@ -161,6 +170,63 @@ public int getExpectedValueAf
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from aa32077d25 Fix wording to explain minAvailableReplicas better in
rebalance UI (#15367)
add a875b1c483 Bump org.as
Jackie-Jiang commented on code in PR #15377:
URL: https://github.com/apache/pinot/pull/15377#discussion_r2017418407
##
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/RoundDecimalTransformFunction.java:
##
@@ -90,8 +90,12 @@ public double[] transformTo
codecov-commenter commented on PR #15383:
URL: https://github.com/apache/pinot/pull/15383#issuecomment-2757045389
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15383?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch fix-null-in-agg-result-block
in repository https://gitbox.apache.org/repos/asf/pinot.git
was d08b34a0c6 Revert the null value handling when nullHandlingEnabled is
false
The revisions that
somandal commented on code in PR #15360:
URL: https://github.com/apache/pinot/pull/15360#discussion_r2017279573
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -208,6 +215,14 @@ private RebalancePreChecker
Jackie-Jiang commented on issue #15348:
URL: https://github.com/apache/pinot/issues/15348#issuecomment-2758914143
Sounds like a Slack issue. Did you get it resolved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
klsince commented on code in PR #15360:
URL: https://github.com/apache/pinot/pull/15360#discussion_r2017203421
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -109,12 +111,17 @@ private RebalancePreChecker
klsince commented on code in PR #15317:
URL: https://github.com/apache/pinot/pull/15317#discussion_r2017149571
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -279,6 +299,43 @@ private RebalancePreCheckerR
Jackie-Jiang commented on code in PR #15383:
URL: https://github.com/apache/pinot/pull/15383#discussion_r2017188192
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##
@@ -2425,10 +2427,22 @@ public void
repa
klsince commented on code in PR #15334:
URL: https://github.com/apache/pinot/pull/15334#discussion_r2017196015
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##
@@ -849,17 +849,29 @@ public void takeSnapshot()
Jackie-Jiang commented on code in PR #15383:
URL: https://github.com/apache/pinot/pull/15383#discussion_r2017186838
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##
@@ -2425,10 +2427,22 @@ public void
repa
Jackie-Jiang opened a new pull request, #15361:
URL: https://github.com/apache/pinot/pull/15361
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
Jackie-Jiang merged PR #15382:
URL: https://github.com/apache/pinot/pull/15382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from eacd6c058a Allows segments deletion in build for pauseless tables
(#15299)
add 772eaea17e Revert the null value h
vrajat commented on code in PR #15387:
URL: https://github.com/apache/pinot/pull/15387#discussion_r2017135992
##
pinot-broker/src/main/java/org/apache/pinot/broker/grpc/BrokerGrpcServer.java:
##
@@ -181,15 +182,17 @@ public void submit(Broker.BrokerRequest request,
try {
KKcorps commented on code in PR #15299:
URL: https://github.com/apache/pinot/pull/15299#discussion_r2016354526
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -1175,6 +1179,136 @@ public SuccessResponse updateTi
This is an automated email from the ASF dual-hosted git repository.
kharekartik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new eacd6c058a Allows segments deletion in build
krishan1390 commented on code in PR #15387:
URL: https://github.com/apache/pinot/pull/15387#discussion_r2016312059
##
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java:
##
@@ -560,6 +568,24 @@ public static Response
getPinotQueryResponse(B
vrajat commented on PR #15387:
URL: https://github.com/apache/pinot/pull/15387#issuecomment-2758614239
> > some of the errors already have meters. e.g.
> > ```
> >
"org.apache.pinot.common.metrics":name="pinot.broker.queryErrorBrokerResourceMissing",type="BrokerMetrics"
> >
"org.ap
vrajat commented on code in PR #15387:
URL: https://github.com/apache/pinot/pull/15387#discussion_r2017024787
##
pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java:
##
@@ -18,195 +18,134 @@
*/
package org.apache.pinot.common.metrics;
+import java.ut
somandal commented on PR #15284:
URL: https://github.com/apache/pinot/pull/15284#issuecomment-2758433231
hey @J-HowHuang is it possible to rebase with latest master to get this
change: https://github.com/apache/pinot/pull/15331/files
And then update your code to add the new tenant info to
krishan1390 commented on code in PR #15387:
URL: https://github.com/apache/pinot/pull/15387#discussion_r2016481851
##
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java:
##
@@ -560,6 +568,24 @@ public static Response
getPinotQueryResponse(B
This is an automated email from the ASF dual-hosted git repository.
kharekartik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 3aeae40e01 Ensure stream consumer is only cl
This is an automated email from the ASF dual-hosted git repository.
pratik pushed a change to branch
dependabot/maven/org.apache.httpcomponents.client5-httpclient5-5.4.3
in repository https://gitbox.apache.org/repos/asf/pinot.git
was f0b427419b Bump org.apache.httpcomponents.client5:httpcl
KKcorps merged PR #15299:
URL: https://github.com/apache/pinot/pull/15299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
dependabot[bot] commented on PR #14989:
URL: https://github.com/apache/pinot/pull/14989#issuecomment-2738014447
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let
mghildiy commented on issue #15381:
URL: https://github.com/apache/pinot/issues/15381#issuecomment-2758153669
I am not sure how much in-depth understanding of pinot codebase is needed
for it. I may give it a try, may be would need guidance from experienced
members.
--
This is an automate
This is an automated email from the ASF dual-hosted git repository.
pratik pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 3aeae40e01 Ensure stream consumer is only closed once (#15372)
add d972923d80 Bump org.apache.httpcomponents.clien
tibrewalpratik17 merged PR #15385:
URL: https://github.com/apache/pinot/pull/15385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@p
mghildiy commented on PR #15377:
URL: https://github.com/apache/pinot/pull/15377#issuecomment-2758049530
I woud work on unit test if code approach is approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
KKcorps merged PR #15372:
URL: https://github.com/apache/pinot/pull/15372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
9aman commented on PR #15299:
URL: https://github.com/apache/pinot/pull/15299#issuecomment-2757748375
> Since we are deleting even the latest consuming segment, are we relying on
RealtimeSegmentValidationManager to create new ones after deletion?
>
> I feel like we should trigger it b
vrajat opened a new pull request, #15388:
URL: https://github.com/apache/pinot/pull/15388
Instructions:
1. The PR has to be tagged with at least one of the following labels (*):
1. `feature`
2. `bugfix`
3. `performance`
4. `ui`
5. `backward-incompat`
6.
albertobastos commented on code in PR #15280:
URL: https://github.com/apache/pinot/pull/15280#discussion_r2016337952
##
pinot-core/src/main/java/org/apache/pinot/core/operator/query/FilteredGroupByOperator.java:
##
@@ -168,12 +170,16 @@ protected GroupByResultsBlock getNextBlock
krishan1390 commented on PR #15387:
URL: https://github.com/apache/pinot/pull/15387#issuecomment-2757926953
> some of the errors already have meters. e.g.
>
> ```
>
"org.apache.pinot.common.metrics":name="pinot.broker.queryErrorBrokerResourceMissing",type="BrokerMetrics"
>
"org
krishan1390 commented on code in PR #15387:
URL: https://github.com/apache/pinot/pull/15387#discussion_r2016483913
##
pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java:
##
@@ -18,195 +18,134 @@
*/
package org.apache.pinot.common.metrics;
+import ja
mghildiy commented on issue #13482:
URL: https://github.com/apache/pinot/issues/13482#issuecomment-2757915155
Is this still valid? If yes, I can work on it.
By description, it seems I would get a better insight into working of
querying working on this.
--
This is an automated message
This is an automated email from the ASF dual-hosted git repository.
pratik pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.31.9
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 26ae08228e Bump software.amazon.awssdk:bom from 2.31.6 to 2.31.9
The revi
This is an automated email from the ASF dual-hosted git repository.
pratik pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 9f54922166 add numGroupsWarningLimitReached stat (#15279)
add cb7b2d7bde Bump software.amazon.awssdk:bom from 2.31
tibrewalpratik17 merged PR #15386:
URL: https://github.com/apache/pinot/pull/15386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@p
vrajat commented on PR #15387:
URL: https://github.com/apache/pinot/pull/15387#issuecomment-2757862603
some of the errors already have meters. e.g.
```
"org.apache.pinot.common.metrics":name="pinot.broker.queryErrorBrokerResourceMissing",type="BrokerMetrics"
"org.apache.pinot.c
9aman commented on code in PR #15299:
URL: https://github.com/apache/pinot/pull/15299#discussion_r2016334411
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -1175,6 +1179,136 @@ public SuccessResponse updateTime
1 - 100 of 135 matches
Mail list logo
