gortiz commented on code in PR #15387: URL: https://github.com/apache/pinot/pull/15387#discussion_r2018025039
########## pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java: ########## @@ -18,195 +18,134 @@ */ package org.apache.pinot.common.metrics; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; import org.apache.pinot.common.Utils; - +import org.apache.pinot.spi.exception.QueryErrorCode; /** - * Enumeration containing all the metrics exposed by the Pinot broker. + * Class containing all the metrics exposed by the Pinot broker. Review Comment: The current metric system is very restrictive. We need to be able to extend it in the future. I don't love this change, but I think it is necessary. Anyway, we are not consuming this class as an enum (ie, applying switches on values of this type or using them as enums in binary representation) so it shouldn't affect us that much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
