rhodo commented on PR #15345: URL: https://github.com/apache/pinot/pull/15345#issuecomment-2759774679
> @rhodo I understand this PR has already been merged but would like to understand following > > 1. What is the rationale of adding this metric. Where would we need this ? > 2. The constant name PROPERTYSTORE_SEGMENT_CHILDREN_BYTE_SIZE gives a perception that it's the size of the child node and not just the segment name sizes. Can we update the name to maybe `PROPERTYSTORE_SEGMENT_CHILDREN_NAME_BYTE_SIZE` ? The rationale is that when the number of segments becomes very large, the getChildren() call could fail or impact availability if the returned list exceeds ZooKeeper's buffer size. This metric helps us monitor and stay ahead of that risk. I don’t have a strong opinion on the naming. I was following the existing convention (e.g., IDEALSTATE_ZNODE_BYTE_SIZE for node size metrics), so I thought PROPERTYSTORE_SEGMENT_ZNODE_BYTE_SIZE might be appropriate if we're tracking znode size. But if you feel strongly about renaming it to something like PROPERTYSTORE_SEGMENT_CHILDREN_NAME_BYTE_SIZE, I’m happy to make that change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
