somandal commented on code in PR #15368: URL: https://github.com/apache/pinot/pull/15368#discussion_r2017709368
########## pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/ControllerRequestURLBuilder.java: ########## @@ -214,7 +214,7 @@ public String forTableRebalance(String tableName, String tableType, boolean dryR if (reassignInstances) { stringBuilder.append("&reassignInstances=").append(reassignInstances); } - if (includeConsuming) { + if (!includeConsuming) { Review Comment: is this a change we need to get in soon? if so, perhaps open a separate PR for this and push to get it in ASAP? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org