krishan1390 commented on code in PR #15387:
URL: https://github.com/apache/pinot/pull/15387#discussion_r2017897838
##########
pinot-broker/src/main/java/org/apache/pinot/broker/grpc/BrokerGrpcServer.java:
##########
@@ -181,15 +182,17 @@ public void submit(Broker.BrokerRequest request,
try {
sqlNodeAndOptions = RequestUtils.parseQuery(query, requestJsonNode);
} catch (Exception e) {
- // Do not log or emit metric here because it is pure user error
Review Comment:
yes in this block currently only SQL_PARSING can be thrown. made the change
primarily to keep the flow consistent with all other changes where we send back
a brokerResponse (sort of making it future proof if more error codes are added
in this block)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
