vrajat commented on PR #15387: URL: https://github.com/apache/pinot/pull/15387#issuecomment-2758614239
> > some of the errors already have meters. e.g. > > ``` > > "org.apache.pinot.common.metrics":name="pinot.broker.queryErrorBrokerResourceMissing",type="BrokerMetrics" > > "org.apache.pinot.common.metrics":name="pinot.broker.queryErrorBrokerSegmentUnavailable",type="BrokerMetrics" > > ``` > > > > > > > > > > > > > > > > > > > > > > > > Maybe you need a list of unreported errors and only report those. > > Yes some errors have appropriate meters like these. But a lot of errors don't and there is a many to many relationship between error codes and metric names. eg: Some SQL_PARSING and some QUERY_PLANNING error code emits a REQUEST_COMPILATION_EXCEPTIONS metric. Some REQUEST_COMPILATION_EXCEPTIONS are emitted for other use cases. There are many more such cases. > > Some metrics might be important in their current form. So refactoring the metrics would be backward incompatible and take a lot of time. > > I thought the simpler option is to create standard metrics in a standard path. This provides us clearer view on what error code is actually returned to the user. So, there will be some redundant metrics but I think thats ok given it moves towards standardization (metrics starting with pinot.broker.queryError) > > Let me know if you still feel otherwise IIUC, there is no double counting ? There will be two metrics possibly that will track the same error type ? for e.g. `queryValidationError` and `queryErrorQueryValidation` ? That sounds reasonable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
