krishan1390 commented on PR #15387: URL: https://github.com/apache/pinot/pull/15387#issuecomment-2757934668
> `BrokerRequestHandlers` is a better place to capture these metrics. Many other metrics are reported there as well. > > https://github.com/apache/pinot/blob/master/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java#L783 > > https://github.com/apache/pinot/blob/master/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java#L167 The problem with BrokerRequestHandlers is many SQL_PARSING errors are thrown before it reaches here. And few client side error codes too around authorization / quota limits etc. While some cases can be considered optional and OK to not track, its a choice. I took the option to track all error codes. Let me know if you still think otherwise -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
