Jackie-Jiang commented on code in PR #15284:
URL: https://github.com/apache/pinot/pull/15284#discussion_r2017529361


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -662,6 +663,20 @@ private RebalanceSummaryResult 
calculateDryRunSummary(Map<String, Map<String, St
     Set<String> serversRemoved = new HashSet<>();
     Set<String> serversUnchanged = new HashSet<>();
     Set<String> serversGettingNewSegments = new HashSet<>();
+    Map<String, RebalanceSummaryResult.TenantInfo> tenantInfoMap = new 
HashMap<>();
+    String serverTenantName = tableConfig.getTenantConfig().getServer();

Review Comment:
   Tag is also coming from `InstanceAssignmentConfig.InstanceTagPoolConfig`



##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java:
##########
@@ -161,6 +170,63 @@ public int getExpectedValueAfterRebalance() {
     }
   }
 
+  public static class TenantInfo {
+    public static final String TENANT_NOT_TAGGED_WITH_TABLE = 
"OUTDATED_SERVERS";
+    private final String _tenantName;
+    private int _numSegmentsUnchanged;
+    private int _numSegmentsToDownload;
+    private int _numServerParticipants;
+
+    @JsonCreator
+    public TenantInfo(
+        @JsonProperty("tenantName") String tenantName,

Review Comment:
   We are actually storing the `tagName` instead of `tenantName`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to