vrajat opened a new pull request, #15374:
URL: https://github.com/apache/pinot/pull/15374
OOM Protection Infra requires the instance type so that it reports to the
right metrics. InstanceType is read from the config `accounting.instance.type`.
This config cannot be set using /CLUSTER/
noob-se7en commented on code in PR #15296:
URL: https://github.com/apache/pinot/pull/15296#discussion_r2012287817
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -1066,7 +1067,7 @@ protected SegmentBuildDescriptor
b
vrajat commented on PR #15346:
URL: https://github.com/apache/pinot/pull/15346#issuecomment-2753325161
I've filed https://github.com/apache/pinot/issues/15373 Lets discuss in that
issue ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
vrajat opened a new issue, #15373:
URL: https://github.com/apache/pinot/issues/15373
There have been a few changes in auth & validation code in
`BaseSingleStageBrokerRequestHandler` in the recent past. A timeline:
* https://github.com/apache/pinot/pull/14953 added an auth check so that
c
deepthi912 commented on code in PR #15332:
URL: https://github.com/apache/pinot/pull/15332#discussion_r2006154419
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableViews.java:
##
@@ -170,6 +186,21 @@ public List
getSegmentStatuses(TableViews.Table
somandal commented on code in PR #15284:
URL: https://github.com/apache/pinot/pull/15284#discussion_r2013264192
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java:
##
@@ -161,6 +170,63 @@ public int getExpectedValueAfte
somandal commented on code in PR #15284:
URL: https://github.com/apache/pinot/pull/15284#discussion_r2013264192
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java:
##
@@ -161,6 +170,63 @@ public int getExpectedValueAfte
Jackie-Jiang merged PR #15370:
URL: https://github.com/apache/pinot/pull/15370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
rhodo commented on PR #15345:
URL: https://github.com/apache/pinot/pull/15345#issuecomment-2752666256
> Can you fix the tests in `SegmentStatusCheckerTest`?
Sure, just fixed. It is failing because propertyStore can be null in
SegmentStatusCheckerTest.
--
This is an automated messag
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013090926
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -693,6 +738,21 @@ private RebalanceSummaryResult
calc
J-HowHuang commented on code in PR #15284:
URL: https://github.com/apache/pinot/pull/15284#discussion_r2013258638
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java:
##
@@ -161,6 +170,63 @@ public int getExpectedValueAf
somandal commented on code in PR #15284:
URL: https://github.com/apache/pinot/pull/15284#discussion_r2013244529
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java:
##
@@ -161,6 +170,63 @@ public int getExpectedValueAfte
somandal commented on code in PR #15317:
URL: https://github.com/apache/pinot/pull/15317#discussion_r2013234329
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java:
##
@@ -826,24 +826,48 @@ public void testRebalancePreCh
This is an automated email from the ASF dual-hosted git repository.
gortiz pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from a875b1c483 Bump org.assertj:assertj-core from 3.27.2 to 3.27.3 (#15365)
add c4d0809a1e Adds a new config to create
somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013192645
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -693,6 +738,21 @@ private RebalanceSummaryResult
calcul
somandal commented on code in PR #15317:
URL: https://github.com/apache/pinot/pull/15317#discussion_r2013206560
##
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancerClusterStatelessTest.java:
##
@@ -669,6 +676,93 @@ public void testRe
somandal commented on code in PR #15317:
URL: https://github.com/apache/pinot/pull/15317#discussion_r2013202143
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -279,6 +299,43 @@ private RebalancePreChecker
somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013184415
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -693,6 +738,21 @@ private RebalanceSummaryResult
calcul
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013166578
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -693,6 +738,21 @@ private RebalanceSummaryResult
calc
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013173960
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -693,6 +738,21 @@ private RebalanceSummaryResult
calc
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013147623
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -693,6 +738,21 @@ private RebalanceSummaryResult
calc
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 3708622b71 Support size based threshold for pauseless consumption
(#15347)
add 44c372b650 ignore .sdkmanrc (#1536
codecov-commenter commented on PR #15372:
URL: https://github.com/apache/pinot/pull/15372#issuecomment-2752842230
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15372?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013106008
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -693,6 +738,21 @@ private RebalanceSummaryResult
calcul
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013108883
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java:
##
@@ -240,6 +240,45 @@ public Map
getServerSegmentC
somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013108450
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -733,15 +793,79 @@ private RebalanceSummaryResult
calcu
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013106376
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -733,15 +793,79 @@ private RebalanceSummaryResult
cal
somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013105304
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -693,6 +738,21 @@ private RebalanceSummaryResult
calcul
somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013099152
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -693,6 +738,21 @@ private RebalanceSummaryResult
calcul
somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013099732
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -693,6 +738,21 @@ private RebalanceSummaryResult
calcul
somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013098032
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -733,15 +793,79 @@ private RebalanceSummaryResult
calcu
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013097701
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -693,6 +738,21 @@ private RebalanceSummaryResult
calc
Jackie-Jiang merged PR #15316:
URL: https://github.com/apache/pinot/pull/15316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013095417
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -733,15 +793,79 @@ private RebalanceSummaryResult
cal
somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013094117
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -693,6 +738,21 @@ private RebalanceSummaryResult
calcul
somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013092611
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -693,6 +738,21 @@ private RebalanceSummaryResult
calcul
somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013091776
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java:
##
@@ -240,6 +240,45 @@ public Map
getServerSegmentCha
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013088194
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -693,6 +738,21 @@ private RebalanceSummaryResult
calc
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 3a6a2f260a Add BrokerGrpcServer for a streaming response fetching
endpoint (#15088)
add 051bf74461 Enhance Ingest
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013082918
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -733,15 +793,79 @@ private RebalanceSummaryResult
cal
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from c4d0809a1e Adds a new config to create a configurable JFR recording in
continuous mode (#15364)
add bfc9c10bed H
somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013086166
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -733,15 +793,79 @@ private RebalanceSummaryResult
calcu
somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013085638
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -733,15 +793,79 @@ private RebalanceSummaryResult
calcu
Jackie-Jiang opened a new pull request, #15372:
URL: https://github.com/apache/pinot/pull/15372
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013081422
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java:
##
@@ -240,6 +240,45 @@ public Map
getServerSegmentC
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013079977
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -733,15 +793,79 @@ private RebalanceSummaryResult
cal
rhodo closed pull request #15363: Add yaml config for exposing
externalviewZnode(Byte)Size metrics
URL: https://github.com/apache/pinot/pull/15363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
somandal commented on code in PR #15266:
URL: https://github.com/apache/pinot/pull/15266#discussion_r2013074065
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -719,23 +741,24 @@ private RebalanceSummaryResult
calcu
Jackie-Jiang commented on code in PR #15296:
URL: https://github.com/apache/pinot/pull/15296#discussion_r2013073512
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -172,6 +172,14 @@ public boolean isFinal() {
}
somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013047959
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -733,15 +793,79 @@ private RebalanceSummaryResult
calcu
J-HowHuang commented on code in PR #15266:
URL: https://github.com/apache/pinot/pull/15266#discussion_r2013049985
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -719,23 +741,24 @@ private RebalanceSummaryResult
cal
codecov-commenter commented on PR #15370:
URL: https://github.com/apache/pinot/pull/15370#issuecomment-2752745059
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15370?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
codecov-commenter commented on PR #15371:
URL: https://github.com/apache/pinot/pull/15371#issuecomment-2752741865
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15371?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
Jackie-Jiang commented on code in PR #15261:
URL: https://github.com/apache/pinot/pull/15261#discussion_r2013034392
##
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/StreamIngestionConfig.java:
##
@@ -43,6 +43,12 @@ public class StreamIngestionConfig extends
ankitsultana opened a new pull request, #15371:
URL: https://github.com/apache/pinot/pull/15371
TODO:
- [ ] Review PRelNode approach. Haven't thought too deeply about it yet. Had
used PRelNode as a wrapper in the PoC and in this I am trying to use concrete
types for each RelNode and
Jackie-Jiang merged PR #15333:
URL: https://github.com/apache/pinot/pull/15333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
yupeng9 commented on issue #15343:
URL: https://github.com/apache/pinot/issues/15343#issuecomment-2752735020
this could be a problem to customers who use Spark/Flink with Pinot.
Java 21 requires Spark4, and it's unclear what version of Flink that can
support Java 21
--
This is an autom
codecov-commenter commented on PR #15369:
URL: https://github.com/apache/pinot/pull/15369#issuecomment-2752721694
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15369?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
rhodo commented on PR #15363:
URL: https://github.com/apache/pinot/pull/15363#issuecomment-2752691917
This actually is not needed, as the external view metrics should have
already be captured by the rule in controller.yml
--
This is an automated message from the Apache Git Service.
To res
xiangfu0 merged PR #15088:
URL: https://github.com/apache/pinot/pull/15088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new ab4f333de8 Enforce schema for all tables (#15333)
J-HowHuang commented on code in PR #15317:
URL: https://github.com/apache/pinot/pull/15317#discussion_r2013011691
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java:
##
@@ -862,31 +881,45 @@ public void testRebalancePre
Jackie-Jiang merged PR #15369:
URL: https://github.com/apache/pinot/pull/15369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang opened a new pull request, #15370:
URL: https://github.com/apache/pinot/pull/15370
- Move the logic of stream config check for multiple streams from
`IngestionConfigUtils` to `TableConfigUtils` so that the check is not applied
for each stream config read
- Reduce unnecessary
rhodo opened a new pull request, #15369:
URL: https://github.com/apache/pinot/pull/15369
[.sdkmanrc](https://sdkman.io/usage/#env-command) can be used to switch to a
specific JDK or SDK every time visit a project in a local setup. Don't want to
commit this to the upstream repo accidentally.
xiangfu0 commented on PR #15333:
URL: https://github.com/apache/pinot/pull/15333#issuecomment-2752623766
> Found it in our logs. Looks like folks should be looking for:
>
> ```
> Found 0 tables misconfigured, 0 tables without schema. Successfully fixed
schema for 0 tables, failed t
Jackie-Jiang closed issue #10091: Verify that pinot-server follows listener
spec for http/https
URL: https://github.com/apache/pinot/issues/10091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch hotfix-array-agg
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 701bba3500 Fix array agg functions to use existing result holder when
present (#15308)
This branch includes t
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from bfc9c10bed HELM: Add TLS-only support and publish 0.3.3 Chart version
(#15356)
add 3708622b71 Support size based
Jackie-Jiang merged PR #15347:
URL: https://github.com/apache/pinot/pull/15347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch hotfix-array-agg
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 701bba35005112f9e5b37cadc98fda3f9f8b9976
Author: Yash Mayya
AuthorDate: Mon Mar 24 18:00:58 2025 +0530
Fix a
somandal commented on code in PR #15330:
URL: https://github.com/apache/pinot/pull/15330#discussion_r2012946135
##
docker/images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml:
##
@@ -48,6 +48,21 @@ rules:
table: "$2$4"
tableType: "$5"
taskType: "$6"
+
Jackie-Jiang commented on code in PR #15330:
URL: https://github.com/apache/pinot/pull/15330#discussion_r2012896634
##
docker/images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml:
##
@@ -48,6 +48,21 @@ rules:
table: "$2$4"
tableType: "$5"
taskType: "$6
Jackie-Jiang commented on PR #15264:
URL: https://github.com/apache/pinot/pull/15264#issuecomment-2752422973
@gortiz I agree that ideally we should throttle the logs with a logging
framework, but people (e.g. LinkedIn) rely on QueryLogger currently to not
flood their log, and if we remove t
codecov-commenter commented on PR #15368:
URL: https://github.com/apache/pinot/pull/15368#issuecomment-2752412034
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15368?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
J-HowHuang opened a new pull request, #15368:
URL: https://github.com/apache/pinot/pull/15368
## Description
To include more info for consuming segments during table rebalance. It's
important because users will likely to experience unexpected Kafka topic
re-consumption. would be better t
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/org.assertj-assertj-core-3.27.3
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 955453368f Bump org.assertj:assertj-core from 3.27.2 to 3.27.3
The revision
xiangfu0 merged PR #15356:
URL: https://github.com/apache/pinot/pull/15356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
xiangfu0 commented on PR #15345:
URL: https://github.com/apache/pinot/pull/15345#issuecomment-2752340040
Can you fix the tests in `SegmentStatusCheckerTest`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
gortiz merged PR #15364:
URL: https://github.com/apache/pinot/pull/15364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
himanish-star commented on code in PR #15331:
URL: https://github.com/apache/pinot/pull/15331#discussion_r2012663014
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceResponse.tsx:
##
@@ -0,0 +1,63 @@
+import {RebalanceServerSecti
codecov-commenter commented on PR #15367:
URL: https://github.com/apache/pinot/pull/15367#issuecomment-2752023599
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15367?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
Jackie-Jiang commented on PR #15356:
URL: https://github.com/apache/pinot/pull/15356#issuecomment-2752013601
I'm not familiar with how helm works. @xiangfu0 Can you help take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
deepthi912 commented on PR #15360:
URL: https://github.com/apache/pinot/pull/15360#issuecomment-2752007903
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
Jackie-Jiang merged PR #15365:
URL: https://github.com/apache/pinot/pull/15365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang merged PR #15355:
URL: https://github.com/apache/pinot/pull/15355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new aa32077d25 Fix wording to explain minAvailableRep
somandal commented on code in PR #15360:
URL: https://github.com/apache/pinot/pull/15360#discussion_r2012571938
##
pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java:
##
@@ -61,34 +61,58 @@ public TableMetadataReader(Executor executor,
Http
Jackie-Jiang commented on code in PR #15347:
URL: https://github.com/apache/pinot/pull/15347#discussion_r2012557652
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##
@@ -1170,14 +1178,15 @@ public void ensur
deepthi912 commented on code in PR #15360:
URL: https://github.com/apache/pinot/pull/15360#discussion_r2012553849
##
pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java:
##
@@ -61,34 +61,58 @@ public TableMetadataReader(Executor executor,
Ht
somandal commented on code in PR #15360:
URL: https://github.com/apache/pinot/pull/15360#discussion_r2012528795
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -97,7 +98,8 @@ public Map
check(PreCheckCont
somandal opened a new pull request, #15367:
URL: https://github.com/apache/pinot/pull/15367
The current explanation of `minAvailableReplicas` in the rebalance UI can be
confusing. This PR updates the wording and adds an example as well.
Testing done:
- Ran `HybridQuickStart` locall
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from b2f7045d7e Make stats system more resilient in MSE (#15312)
add cf22310858 Fix pauseless consumption segment downl
somandal commented on code in PR #15360:
URL: https://github.com/apache/pinot/pull/15360#discussion_r2012510847
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -97,7 +98,8 @@ public Map
check(PreCheckCont
deepthi912 commented on code in PR #15360:
URL: https://github.com/apache/pinot/pull/15360#discussion_r2012501373
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -97,7 +98,8 @@ public Map
check(PreCheckCo
siddharthteotia commented on PR #15346:
URL: https://github.com/apache/pinot/pull/15346#issuecomment-2751821054
Thanks for the prompt help @vrajat @gortiz
What is the next step on this in terms of taking it forward for what you
originally wanted to do ? Is there a new PR / issue whe
somandal commented on code in PR #15331:
URL: https://github.com/apache/pinot/pull/15331#discussion_r2012441309
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerResponses/RebalanceServerPreChecksResponse.tsx:
##
@@ -0,0 +1,
somandal commented on code in PR #15331:
URL: https://github.com/apache/pinot/pull/15331#discussion_r2012438995
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerResponses/RebalanceServerRebalanceSummaryResponse.tsx:
##
@@ -
somandal commented on code in PR #15331:
URL: https://github.com/apache/pinot/pull/15331#discussion_r2012435827
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceResponse.tsx:
##
@@ -0,0 +1,63 @@
+import {RebalanceServerSection} f
noob-se7en commented on code in PR #15296:
URL: https://github.com/apache/pinot/pull/15296#discussion_r2012380660
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -1723,6 +1725,15 @@ public RealtimeSegmentDataManager(
1 - 100 of 138 matches
Mail list logo