deepthi912 commented on code in PR #15360:
URL: https://github.com/apache/pinot/pull/15360#discussion_r2012501373
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##########
@@ -97,7 +98,8 @@ public Map<String, RebalancePreCheckerResult>
check(PreCheckContext preCheckCont
* TODO: Add an API to check for whether segments in deep store are up to
date with the table configs and schema
* and add a pre-check here to call that API.
*/
- private RebalancePreCheckerResult checkReloadNeededOnServers(String
rebalanceJobId, String tableNameWithType) {
+ private RebalancePreCheckerResult checkReloadNeededOnServers(String
rebalanceJobId, String tableNameWithType,
Review Comment:
Trying to understand the preCheckContext.getCurrentAssignment() better, does
it get the current assignment from the IS? If for some reason, if the servers
IS & EV don't match. Will that create any major concerns with this response?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
