vrajat opened a new pull request, #15374:
URL: https://github.com/apache/pinot/pull/15374

   OOM Protection Infra requires the instance type so that it reports to the 
right metrics. InstanceType is read from the config `accounting.instance.type`.
   
   This config cannot be set using /CLUSTER/CONFIGS API since it is 
multi-valued. It can only be set using `-configFileName` in the command line.
   
   Moreover, the instance type is known during startup as the code is 
initialized from either BaseBrokerStarter or BaseServerStarter. Also it should 
not be configurable.
   
   Therefore the config parameter has been removed. This is OK as unknown 
config parameters are ignored. InstanceType is passed as a parameter during 
initialization.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to