J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013147623
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -693,6 +738,21 @@ private RebalanceSummaryResult
calculateDryRunSummary(Map<String, Map<String, St
if (segmentsAdded > 0) {
serversGettingNewSegments.add(server);
}
+ if (!isOfflineTable) {
+ if (bytesToCatchUpForServers != null) {
+ bytesToCatchUpForServers.put(server, 0);
+ }
+ for (String segment : newSegmentSet) {
+ if (consumingSegments.contains(segment)) {
+ consumingSegmentsToBeMoved++;
+ if (bytesToCatchUpForSegments != null) {
Review Comment:
If there's no consuming segment, the return value would be an empty map
instead of `null`, so the view in the summary will be
`maxBytesToCatchUpForConsumingSegments=0` and `bytesToCatchUpForServer` having
its values all zeros.
As for the failed requests from servers, as long as we have at least one
server successfully responded for every consuming segment, the information
would be valid. If not (like the example below), a `null` will return and
directly disable this part of summary, because I believe this is not a detail
we want to provide to the user of rebalance summary, right? For debugging,
there should be different warning log for each error scenarios.
```
{
"serversFailingToRespond": 1,
"serversUnparsableRespond": 0,
"_segmentToConsumingInfoMap": {
"transcript__0__0__20250325T1937Z": [],
"transcript__1__0__20250325T1937Z": []
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
