J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013097701
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -693,6 +738,21 @@ private RebalanceSummaryResult
calculateDryRunSummary(Map<String, Map<String, St
if (segmentsAdded > 0) {
serversGettingNewSegments.add(server);
}
+ if (!isOfflineTable) {
+ if (bytesToCatchUpForServers != null) {
+ bytesToCatchUpForServers.put(server, 0);
+ }
Review Comment:
Like a missing server could mean an error to me? Maybe the info wasn't
fetched successfully, or the server list is inconsistent across the whole
process.
I could make this into serverInfo since it's already there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
