somandal commented on code in PR #15330:
URL: https://github.com/apache/pinot/pull/15330#discussion_r2012946135
##########
docker/images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml:
##########
@@ -48,6 +48,21 @@ rules:
table: "$2$4"
tableType: "$5"
taskType: "$6"
+ # Special handling for timers like cronSchedulerJobExecutionTimeMs and
tableRebalanceExecutionTimeMs
Review Comment:
@Jackie-Jiang I had tried combining `cronSchedulerJobScheduled` with these
before as well, but unfortunately that rule doesn't apply to these.
for `cronSchedulerJobScheduled`: `fullGaugeName` =
`cronSchedulerJobScheduled.myTable_REALTIME.ClusterHealthCheck`
whereas `cronSchedulerJobExecutionTimeMs` and
`tableRebalanceExecutionTimeMs` are timer types, and they are in the format:
`pinot.controller.myTable_REALTIME.DONE.tableRebalanceExecutionTimeMs` or
`pinot.controller.myTable_REALTIME.SegmentImportTask.cronSchedulerJobExecutionTimeMs`
So the position of the metric name varies in both
Also @suddendust and I didn't want to combine
`cronSchedulerJobExecutionTimeMs` and `tableRebalanceExecutionTimeMs` into the
same since one is the `taskType` and other is the `status` (rebalance job
status), and combining them will be confusing.
let me know if you have any other thoughts around the above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
