somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013094117
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -693,6 +738,21 @@ private RebalanceSummaryResult
calculateDryRunSummary(Map<String, Map<String, St
if (segmentsAdded > 0) {
serversGettingNewSegments.add(server);
}
+ if (!isOfflineTable) {
+ if (bytesToCatchUpForServers != null) {
+ bytesToCatchUpForServers.put(server, 0);
+ }
+ for (String segment : newSegmentSet) {
+ if (consumingSegments.contains(segment)) {
+ consumingSegmentsToBeMoved++;
+ if (bytesToCatchUpForSegments != null) {
Review Comment:
what i meant is that there seem to be many error scenarios that result in
`bytesToCatchUpForSegments = null`. I meant capturing some data about the error
scenarios. How can I differentiate between having no consuming segment to worry
about vs. being unable to fetch the consuming segments data?
Similarly, I believe that the request to fetch the consuming segments data
also captured number of failed requests from servers. should we bubble that up
as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
