Re: [PR] Bump pulsar.version from 3.3.1 to 4.0.3 [pinot]

2025-02-28 Thread via GitHub
dependabot[bot] commented on PR #15152: URL: https://github.com/apache/pinot/pull/15152#issuecomment-2691422641 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by

Re: [PR] Upgrade Pulsar to 4.0.3 [pinot]

2025-02-28 Thread via GitHub
Jackie-Jiang merged PR #15157: URL: https://github.com/apache/pinot/pull/15157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Make ser/de part of the AggregationFunction [pinot]

2025-02-28 Thread via GitHub
codecov-commenter commented on PR #15158: URL: https://github.com/apache/pinot/pull/15158#issuecomment-2691900738 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15158?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] [draft]Add a new distinctCountGlobal function [pinot]

2025-02-28 Thread via GitHub
xiangfu0 closed pull request #15117: [draft]Add a new distinctCountGlobal function URL: https://github.com/apache/pinot/pull/15117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Fix issue of trailing / in the path for gcs [pinot]

2025-02-28 Thread via GitHub
9aman commented on code in PR #15155: URL: https://github.com/apache/pinot/pull/15155#discussion_r1975926133 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java: ## @@ -349,23 +350,36 @@ public void removeAgedDeletedSegments(Lead

[PR] Make ser/de part of the AggregationFunction [pinot]

2025-02-28 Thread via GitHub
Jackie-Jiang opened a new pull request, #15158: URL: https://github.com/apache/pinot/pull/15158 Currently aggregation ser/de is handled by `ObjectSerDeUtils`. It has the following drawbacks: - Ser/de is not self-contained in the `AggregationFunction` - Hard to maintain backward compati

Re: [PR] Logical poc [pinot]

2025-02-28 Thread via GitHub
ankitsultana commented on PR #15151: URL: https://github.com/apache/pinot/pull/15151#issuecomment-2691796187 @vrajat : any PEP or design doc for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

(pinot) branch master updated: Upgrade Pulsar to 4.0.3 (#15157)

2025-02-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 9c7aef745d Upgrade Pulsar to 4.0.3 (#15157) 9c7ae

Re: [I] Ingest: update Pulsar to 4.0 LTS [pinot]

2025-02-28 Thread via GitHub
Jackie-Jiang closed issue #14543: Ingest: update Pulsar to 4.0 LTS URL: https://github.com/apache/pinot/issues/14543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Enable force overwrite for partial upserts [pinot]

2025-02-28 Thread via GitHub
deemoliu commented on code in PR #15107: URL: https://github.com/apache/pinot/pull/15107#discussion_r1976093775 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/merger/PartialUpsertColumnarMerger.java: ## @@ -74,7 +75,10 @@ public void merge(LazyRow pre

Re: [PR] Upgrade Pulsar to 4.0.3 [pinot]

2025-02-28 Thread via GitHub
codecov-commenter commented on PR #15157: URL: https://github.com/apache/pinot/pull/15157#issuecomment-2691544006 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15157?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] MSE throttling: Set a hard limit on number of MSE threads [pinot]

2025-02-28 Thread via GitHub
Jackie-Jiang commented on code in PR #15143: URL: https://github.com/apache/pinot/pull/15143#discussion_r1975980844 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -248,6 +248,9 @@ public static class Instance { public static final String

Re: [PR] Re-order Aggregation Optimizations [pinot]

2025-02-28 Thread via GitHub
J-HowHuang commented on code in PR #15138: URL: https://github.com/apache/pinot/pull/15138#discussion_r1975982749 ## pinot-core/src/test/java/org/apache/pinot/queries/ExplainPlanQueriesTest.java: ## @@ -2301,13 +2298,12 @@ public void testSelectAggregateUsingFilterIndexVerbose(

[PR] Upgrade Pulsar to 4.0.3 [pinot]

2025-02-28 Thread via GitHub
Jackie-Jiang opened a new pull request, #15157: URL: https://github.com/apache/pinot/pull/15157 Close #14543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Add DISTINCT_COUNT_HIGH_CARDINALITY function [pinot]

2025-02-28 Thread via GitHub
Jackie-Jiang commented on code in PR #15149: URL: https://github.com/apache/pinot/pull/15149#discussion_r1975948391 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountHighCardinalityAggregationFunction.java: ## @@ -0,0 +1,253 @@ +/** + * Li

Re: [PR] Add DISTINCT_COUNT_HIGH_CARDINALITY function [pinot]

2025-02-28 Thread via GitHub
ashishjayamohan commented on code in PR #15149: URL: https://github.com/apache/pinot/pull/15149#discussion_r1975951176 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountHighCardinalityAggregationFunction.java: ## @@ -0,0 +1,253 @@ +/** + *

Re: [PR] Add DISTINCT_COUNT_HIGH_CARDINALITY function [pinot]

2025-02-28 Thread via GitHub
Jackie-Jiang commented on code in PR #15149: URL: https://github.com/apache/pinot/pull/15149#discussion_r1975940592 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountHighCardinalityAggregationFunction.java: ## @@ -0,0 +1,253 @@ +/** + * Li

(pinot) branch master updated (fdd6a1aa86 -> 941c93daf8)

2025-02-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from fdd6a1aa86 Fix issue of trailing / in the path for gcs (#15155) add 941c93daf8 Bump com.microsoft.azure:msal4j fro

(pinot) branch dependabot/maven/com.microsoft.azure-msal4j-1.19.1 deleted (was 31fa5c0e68)

2025-02-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.microsoft.azure-msal4j-1.19.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was 31fa5c0e68 Bump com.microsoft.azure:msal4j from 1.19.0 to 1.19.1 The revi

Re: [PR] Bump com.microsoft.azure:msal4j from 1.19.0 to 1.19.1 [pinot]

2025-02-28 Thread via GitHub
Jackie-Jiang merged PR #15153: URL: https://github.com/apache/pinot/pull/15153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[PR] Upgrade pulsar to 3.3.5 [pinot]

2025-02-28 Thread via GitHub
Jackie-Jiang opened a new pull request, #15156: URL: https://github.com/apache/pinot/pull/15156 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Fix issue of trailing / in the path for gcs [pinot]

2025-02-28 Thread via GitHub
xiangfu0 merged PR #15155: URL: https://github.com/apache/pinot/pull/15155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated (51e7b84bd2 -> fdd6a1aa86)

2025-02-28 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 51e7b84bd2 Bump software.amazon.awssdk:bom from 2.30.28 to 2.30.30 (#15154) add fdd6a1aa86 Fix issue of trailing

Re: [PR] Fix issue of trailing / in the path for gcs [pinot]

2025-02-28 Thread via GitHub
xiangfu0 commented on code in PR #15155: URL: https://github.com/apache/pinot/pull/15155#discussion_r1975927119 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java: ## @@ -349,23 +350,36 @@ public void removeAgedDeletedSegments(L

Re: [PR] MSE throttling: Set a hard limit on number of MSE threads [pinot]

2025-02-28 Thread via GitHub
albertobastos commented on code in PR #15143: URL: https://github.com/apache/pinot/pull/15143#discussion_r1975905037 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java: ## @@ -174,9 +174,14 @@ public void init(PinotConfiguration config, Instanc

Re: [PR] MSE throttling: Set a hard limit on number of MSE threads [pinot]

2025-02-28 Thread via GitHub
albertobastos commented on code in PR #15143: URL: https://github.com/apache/pinot/pull/15143#discussion_r1975907262 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java: ## @@ -177,6 +178,12 @@ public void init(PinotConfiguration config, Instanc

Re: [PR] MSE throttling: Set a hard limit on number of MSE threads [pinot]

2025-02-28 Thread via GitHub
albertobastos commented on code in PR #15143: URL: https://github.com/apache/pinot/pull/15143#discussion_r1975906078 ## pinot-spi/src/main/java/org/apache/pinot/spi/executor/ExecutorServiceUtils.java: ## @@ -132,4 +133,14 @@ public static void close(ExecutorService executorServi

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975584205 ## pinot-spi/src/main/java/org/apache/pinot/spi/exception/QueryErrorMessage.java: ## @@ -0,0 +1,94 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on PR #15037: URL: https://github.com/apache/pinot/pull/15037#issuecomment-2691010316 I've pushed several changes to fix most of the comments from @yashmayya. I think I also commented on the open discussions -- This is an automated message from the Apache Git Service. To

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975647555 ## pinot-spi/src/main/java/org/apache/pinot/spi/exception/QueryException.java: ## @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975580497 ## pinot-spi/src/main/java/org/apache/pinot/spi/exception/EarlyTerminationException.java: ## @@ -22,17 +22,17 @@ * The {@code EarlyTerminationException} can be thrown

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975628058 ## pinot-core/src/main/java/org/apache/pinot/core/operator/streaming/StreamingInstanceResponseOperator.java: ## @@ -89,11 +89,12 @@ protected InstanceResponseBlock getNe

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975628058 ## pinot-core/src/main/java/org/apache/pinot/core/operator/streaming/StreamingInstanceResponseOperator.java: ## @@ -89,11 +89,12 @@ protected InstanceResponseBlock getNe

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975625657 ## pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseSingleBlockCombineOperator.java: ## @@ -112,11 +113,17 @@ protected void processSegments() { @O

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975592710 ## pinot-spi/src/main/java/org/apache/pinot/spi/exception/QueryErrorMessage.java: ## @@ -0,0 +1,94 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975623209 ## pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseSingleBlockCombineOperator.java: ## @@ -65,7 +66,7 @@ protected BaseResultsBlock getNextBlock() {

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975619798 ## pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java: ## @@ -190,16 +191,21 @@ protected static RuntimeException wrapOperatorExce

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975576427 ## pinot-spi/src/main/java/org/apache/pinot/spi/exception/QueryErrorCode.java: ## @@ -0,0 +1,141 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Fix issue of trailing / in the path for gcs [pinot]

2025-02-28 Thread via GitHub
swaminathanmanish commented on code in PR #15155: URL: https://github.com/apache/pinot/pull/15155#discussion_r1975482332 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java: ## @@ -349,23 +350,36 @@ public void removeAgedDeletedS

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975563360 ## pinot-common/src/main/java/org/apache/pinot/common/datablock/DataBlock.java: ## @@ -41,10 +42,15 @@ public interface DataBlock { int getNumberOfColumns(); + @

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975549617 ## pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseNative.java: ## @@ -59,16 +59,16 @@ public class BrokerResponseNative implements Bro

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975562169 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java: ## @@ -726,18 +722,18 @@ protected BrokerResponse doHandle

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975559186 ## pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseNative.java: ## @@ -59,16 +59,16 @@ public class BrokerResponseNative implements Bro

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975547455 ## pinot-common/src/main/java/org/apache/pinot/common/function/FunctionInvoker.java: ## @@ -112,7 +113,11 @@ public void convertTypes(Object[] arguments) { PinotD

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975530174 ## pinot-common/src/main/java/org/apache/pinot/common/datablock/DataBlockUtils.java: ## @@ -97,18 +98,22 @@ private DataBlockUtils() { public static MetadataBlock g

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975539639 ## pinot-common/src/main/java/org/apache/pinot/common/datatable/DataTable.java: ## @@ -36,10 +37,15 @@ */ public interface DataTable { + @Deprecated void addExc

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975539639 ## pinot-common/src/main/java/org/apache/pinot/common/datatable/DataTable.java: ## @@ -36,10 +37,15 @@ */ public interface DataTable { + @Deprecated void addExc

Re: [PR] Bump software.amazon.awssdk:bom from 2.30.28 to 2.30.30 [pinot]

2025-02-28 Thread via GitHub
yashmayya merged PR #15154: URL: https://github.com/apache/pinot/pull/15154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975524355 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java: ## @@ -222,16 +222,16 @@ protected BrokerResponse handleRequest

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975514955 ## pinot-common/src/main/java/org/apache/pinot/common/response/BrokerResponse.java: ## @@ -76,11 +76,11 @@ default void toOutputStream(OutputStream outputStream) /**

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975514955 ## pinot-common/src/main/java/org/apache/pinot/common/response/BrokerResponse.java: ## @@ -76,11 +76,11 @@ default void toOutputStream(OutputStream outputStream) /**

Re: [PR] Fix issue of trailing / in the path for gcs [pinot]

2025-02-28 Thread via GitHub
codecov-commenter commented on PR #15155: URL: https://github.com/apache/pinot/pull/15155#issuecomment-2690753120 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15155?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.30.30 deleted (was d95ea1f023)

2025-02-28 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.30.30 in repository https://gitbox.apache.org/repos/asf/pinot.git was d95ea1f023 Bump software.amazon.awssdk:bom from 2.30.28 to 2.30.30 Th

(pinot) branch master updated (fd3b079615 -> 51e7b84bd2)

2025-02-28 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from fd3b079615 Refactor DispatchableSubPlan to store fragments by stage id (#15135) add 51e7b84bd2 Bump software.a

(pinot) branch master updated: Refactor DispatchableSubPlan to store fragments by stage id (#15135)

2025-02-28 Thread gortiz
This is an automated email from the ASF dual-hosted git repository. gortiz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new fd3b079615 Refactor DispatchableSubPlan to store

Re: [PR] Refactor DispatchableSubPlan to store fragments by stage id [pinot]

2025-02-28 Thread via GitHub
gortiz merged PR #15135: URL: https://github.com/apache/pinot/pull/15135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-02-28 Thread via GitHub
yashmayya commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1975177226 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java: ## @@ -368,9 +364,10 @@ protected BrokerResponse handleReque

Re: [PR] MSE throttling: Set a hard limit on number of MSE threads [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15143: URL: https://github.com/apache/pinot/pull/15143#discussion_r1975455876 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java: ## @@ -177,6 +178,12 @@ public void init(PinotConfiguration config, InstanceDataMa

Re: [PR] MSE throttling: Set a hard limit on number of MSE threads [pinot]

2025-02-28 Thread via GitHub
gortiz commented on code in PR #15143: URL: https://github.com/apache/pinot/pull/15143#discussion_r1975452181 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/server/ServerPlanRequestUtils.java: ## @@ -106,7 +106,7 @@ public static OpChain compileLeafSta

[PR] Fix issue of trailing / in the path for gcs [pinot]

2025-02-28 Thread via GitHub
9aman opened a new pull request, #15155: URL: https://github.com/apache/pinot/pull/15155 ## Issue The GcsPinotFS returns directories names with training "/" unlike S3PinotFS and LocalPinotFS. This leads to issue in deletion of segments by the retention manager as it expects sanitized

Re: [PR] Enable force overwrite for partial upserts [pinot]

2025-02-28 Thread via GitHub
tibrewalpratik17 commented on PR #15107: URL: https://github.com/apache/pinot/pull/15107#issuecomment-2690667837 LGTM! cc @Jackie-Jiang @klsince in case you have any comments! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] MSE throttling: Set a hard limit on number of MSE threads [pinot]

2025-02-28 Thread via GitHub
albertobastos commented on code in PR #15143: URL: https://github.com/apache/pinot/pull/15143#discussion_r1975237338 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -1065,6 +1065,9 @@ public static class SegmentCompletionProtocol { public

[PR] Bump pulsar.version from 3.3.1 to 4.0.3 [pinot]

2025-02-28 Thread via GitHub
dependabot[bot] opened a new pull request, #15152: URL: https://github.com/apache/pinot/pull/15152 Bumps `pulsar.version` from 3.3.1 to 4.0.3. Updates `org.apache.pulsar:pulsar-client` from 3.3.1 to 4.0.3 Release notes Sourced from https://github.com/apache/pulsar/releases";>org.

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.30.29 deleted (was 0860722128)

2025-02-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.30.29 in repository https://gitbox.apache.org/repos/asf/pinot.git was 0860722128 Bump software.amazon.awssdk:bom from 2.30.28 to 2.30.29 T

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.30.30 created (now d95ea1f023)

2025-02-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.30.30 in repository https://gitbox.apache.org/repos/asf/pinot.git at d95ea1f023 Bump software.amazon.awssdk:bom from 2.30.28 to 2.30.30 N

[PR] Bump software.amazon.awssdk:bom from 2.30.28 to 2.30.30 [pinot]

2025-02-28 Thread via GitHub
dependabot[bot] opened a new pull request, #15154: URL: https://github.com/apache/pinot/pull/15154 Bumps software.amazon.awssdk:bom from 2.30.28 to 2.30.30. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- |

Re: [PR] Bump software.amazon.awssdk:bom from 2.30.28 to 2.30.29 [pinot]

2025-02-28 Thread via GitHub
dependabot[bot] commented on PR #15145: URL: https://github.com/apache/pinot/pull/15145#issuecomment-2690370597 Superseded by #15154. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump software.amazon.awssdk:bom from 2.30.28 to 2.30.29 [pinot]

2025-02-28 Thread via GitHub
dependabot[bot] closed pull request #15145: Bump software.amazon.awssdk:bom from 2.30.28 to 2.30.29 URL: https://github.com/apache/pinot/pull/15145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

(pinot) branch dependabot/maven/com.microsoft.azure-msal4j-1.19.1 created (now 31fa5c0e68)

2025-02-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.microsoft.azure-msal4j-1.19.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at 31fa5c0e68 Bump com.microsoft.azure:msal4j from 1.19.0 to 1.19.1 No n

[PR] Bump com.microsoft.azure:msal4j from 1.19.0 to 1.19.1 [pinot]

2025-02-28 Thread via GitHub
dependabot[bot] opened a new pull request, #15153: URL: https://github.com/apache/pinot/pull/15153 Bumps [com.microsoft.azure:msal4j](https://github.com/AzureAD/microsoft-authentication-library-for-java) from 1.19.0 to 1.19.1. Changelog Sourced from https://github.com/AzureAD/micr

(pinot) branch dependabot/maven/pulsar.version-4.0.3 created (now eadfcd65e7)

2025-02-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/pulsar.version-4.0.3 in repository https://gitbox.apache.org/repos/asf/pinot.git at eadfcd65e7 Bump pulsar.version from 3.3.1 to 4.0.3 No new revisions were added by t

(pinot) branch master updated (ec87186017 -> a0037d3be8)

2025-02-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from ec87186017 Replace More String.format() References With Concatenation (#15148) add a0037d3be8 Nit: Fix Error Mess

Re: [PR] MSE throttling: Set a hard limit on number of MSE threads [pinot]

2025-02-28 Thread via GitHub
albertobastos commented on code in PR #15143: URL: https://github.com/apache/pinot/pull/15143#discussion_r1975012300 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/MdcQueryExecutor.java: ## @@ -0,0 +1,108 @@ +/** + * Licensed to the Apache Software Foundation (