gortiz commented on code in PR #15037:
URL: https://github.com/apache/pinot/pull/15037#discussion_r1975524355
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -222,16 +222,16 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
() -> finalQueryEnvironment.planQuery(query,
sqlNodeAndOptions, requestId),
queryTimer.getRemainingTime());
} catch (TimeoutException | InterruptedException e) {
-
requestContext.setErrorCode(QueryException.BROKER_TIMEOUT_ERROR_CODE);
- return new
BrokerResponseNative(QueryException.BROKER_TIMEOUT_ERROR);
+ requestContext.setErrorCode(QueryErrorCode.BROKER_TIMEOUT);
+ return new BrokerResponseNative(QueryErrorCode.BROKER_TIMEOUT,
"BrokerTimeoutError");
Review Comment:
I think in general we need to cleanup all the error codes. But you are
right, let's try to keep this PR as simple as possible.
But I'm changing the literal as you mention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
