gortiz commented on code in PR #15037:
URL: https://github.com/apache/pinot/pull/15037#discussion_r1975514955
##########
pinot-common/src/main/java/org/apache/pinot/common/response/BrokerResponse.java:
##########
@@ -76,11 +76,11 @@ default void toOutputStream(OutputStream outputStream)
/**
* Returns the processing exceptions encountered during the query execution.
*/
- List<QueryProcessingException> getExceptions();
+ List<BrokerResponseErrorMessage> getExceptions();
Review Comment:
I had a hard time deciding where to stop refactoring. If you think it is
fine I can change it, but it is being used more than 100 times, so expect to
add that number of changes on this already long PR.
I would prefer to apply that change in a new and simpler PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
