albertobastos commented on code in PR #15143:
URL: https://github.com/apache/pinot/pull/15143#discussion_r1975905037
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java:
##########
@@ -174,9 +174,14 @@ public void init(PinotConfiguration config,
InstanceDataManager instanceDataMana
String joinOverflowModeStr =
config.getProperty(CommonConstants.MultiStageQueryRunner.KEY_OF_JOIN_OVERFLOW_MODE);
_joinOverflowMode = joinOverflowModeStr != null ?
JoinOverFlowMode.valueOf(joinOverflowModeStr) : null;
- _executorService =
- ExecutorServiceUtils.create(config,
Server.MULTISTAGE_EXECUTOR_CONFIG_PREFIX, "query-runner-on-" + port,
- Server.DEFAULT_MULTISTAGE_EXECUTOR_TYPE);
+ int hardLimit =
ExecutorServiceUtils.getMultiStageExecutorHardLimit(config);
+ String executorType = Server.DEFAULT_MULTISTAGE_EXECUTOR_TYPE;
+ if (hardLimit > 0) {
+ executorType = "hardlimit";
+ }
+ _executorService = ExecutorServiceUtils.create(config,
Server.MULTISTAGE_EXECUTOR_CONFIG_PREFIX,
+ "query-runner-on-" + port, executorType);
Review Comment:
Yep, definitely I overstepped trying to use the Provider API for that.
5a451ae6ca1239c679323725066c457b47d6e2b1
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/server/ServerPlanRequestUtils.java:
##########
@@ -106,7 +106,7 @@ public static OpChain
compileLeafStage(OpChainExecutionContext executionContext,
BiConsumer<PlanNode, MultiStageOperator> relationConsumer,
boolean explain) {
long queryArrivalTimeMs = System.currentTimeMillis();
- MdcExecutor mdcExecutor = new MdcExecutor(executorService) {
+ ExecutorService decoratedExecutor = new MdcExecutor(executorService) {
Review Comment:
You guessed it... it made sense before, but no longer does. Undone.
5a451ae6ca1239c679323725066c457b47d6e2b1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
