albertobastos commented on code in PR #15143: URL: https://github.com/apache/pinot/pull/15143#discussion_r1975012300
########## pinot-core/src/main/java/org/apache/pinot/core/query/executor/MdcQueryExecutor.java: ########## @@ -0,0 +1,108 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.executor; + +import java.util.concurrent.Callable; +import java.util.concurrent.ExecutorService; +import org.apache.pinot.spi.executor.DecoratorExecutorService; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * A delegator executor service that sets MDC context for the query. + * + * By using this executor, all tasks submitted to the executor will have the MDC context set to the query context. + * This is easier and safer to apply than setting the MDC context manually for each task. + * You can read more about MDC in <a href="https://www.baeldung.com/mdc-in-log4j-2-logback";>this baeldung post</a> + * + * TODO: Convert this class and its usages into an Executor instead of an ExecutorService + * + */ +public abstract class MdcQueryExecutor extends DecoratorExecutorService { Review Comment: Yeah, bringing @gortiz changes to my branch before they were definitive lead to a bit of a mess after it changed several things. Did the rebase, it all should make sense now. Gonna attend the rest of PR comments now. ########## pinot-core/src/main/java/org/apache/pinot/core/query/executor/MdcQueryExecutor.java: ########## @@ -0,0 +1,108 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.executor; + +import java.util.concurrent.Callable; +import java.util.concurrent.ExecutorService; +import org.apache.pinot.spi.executor.DecoratorExecutorService; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * A delegator executor service that sets MDC context for the query. + * + * By using this executor, all tasks submitted to the executor will have the MDC context set to the query context. + * This is easier and safer to apply than setting the MDC context manually for each task. + * You can read more about MDC in <a href="https://www.baeldung.com/mdc-in-log4j-2-logback";>this baeldung post</a> + * + * TODO: Convert this class and its usages into an Executor instead of an ExecutorService + * + */ +public abstract class MdcQueryExecutor extends DecoratorExecutorService { Review Comment: Yeah, bringing @gortiz changes to my branch before they were definitive led to a bit of a mess after it changed several things. Did the rebase, it all should make sense now. Gonna attend the rest of PR comments now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
