gortiz commented on code in PR #15037:
URL: https://github.com/apache/pinot/pull/15037#discussion_r1975580497
##########
pinot-spi/src/main/java/org/apache/pinot/spi/exception/EarlyTerminationException.java:
##########
@@ -22,17 +22,17 @@
* The {@code EarlyTerminationException} can be thrown from
{Operator#nextBlock()} when the operator is early
* terminated (interrupted).
*/
-public class EarlyTerminationException extends RuntimeException {
+public class EarlyTerminationException extends QueryException {
public EarlyTerminationException() {
- super();
+ super(QueryErrorCode.INTERNAL);
Review Comment:
TBH, I changed this class to extend QueryException because @vrajat suggested
that, but the more I think about it, the less I like the idea. This is not an
exception that will ever pop up to the user. Instead, it is just our own
InterruptedException.
Anyway, let's think about what to do with this exception in the following PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
