gortiz commented on code in PR #15037:
URL: https://github.com/apache/pinot/pull/15037#discussion_r1975539639
##########
pinot-common/src/main/java/org/apache/pinot/common/datatable/DataTable.java:
##########
@@ -36,10 +37,15 @@
*/
public interface DataTable {
+ @Deprecated
void addException(ProcessingException processingException);
void addException(int exceptionCode, String exceptionMsg);
+ default void addException(QueryErrorCode exceptionCode, String exceptionMsg)
{
Review Comment:
Yes. We can remove the others. I optimistically kept the other method to try
to not break third party plugins, but TBH all other changes probably are more
invasive than this one
EDIT: No, the one with ints is also being used. The one that can be removed
is the one that receives ProcessingExceptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
