deemoliu commented on code in PR #15107:
URL: https://github.com/apache/pinot/pull/15107#discussion_r1976093775
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/merger/PartialUpsertColumnarMerger.java:
##########
@@ -74,7 +75,10 @@ public void merge(LazyRow previousRow, GenericRow newRow,
Map<String, Object> re
// (1) If the value of the previous is null value, skip merging and use
the new value
// (2) Else If the value of new value is null, use the previous value
(even for comparison columns)
// (3) Else If the column is not a comparison column, we applied the
merged value to it
- if (!(merger instanceof OverwriteMerger)) {
+ if (merger instanceof ForceOverwriteMerger) {
Review Comment:
please add some comment Similar to Overwrite mergers.
If the merge strategy is force overwrite merger, always use the new value no
matter what it's.
The idea is to minimize the access to the previous row value to reduce disk
IO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
