Re: [PR] Compatible dropwizard metrics [pinot]

2024-10-23 Thread via GitHub
gortiz merged PR #9416: URL: https://github.com/apache/pinot/pull/9416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.

(pinot) branch master updated: Compound metric plugin

2024-10-23 Thread gortiz
This is an automated email from the ASF dual-hosted git repository. gortiz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new f251f00182 Compound metric plugin f251f00182 is d

(pinot) branch master updated: Speed up dev build. (#14210)

2024-10-23 Thread gortiz
This is an automated email from the ASF dual-hosted git repository. gortiz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 6a63a127ad Speed up dev build. (#14210) 6a63a127a

Re: [I] Do not allow setters in `IndexLoadingConfig` [pinot]

2024-10-23 Thread via GitHub
Jackie-Jiang closed issue #14106: Do not allow setters in `IndexLoadingConfig` URL: https://github.com/apache/pinot/issues/14106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Deprecate _segmentAssignmentStrategy in SegmentsValidationAndRetentionConfig [pinot]

2024-10-23 Thread via GitHub
Jackie-Jiang commented on code in PR #11869: URL: https://github.com/apache/pinot/pull/11869#discussion_r1814211853 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/IngestionConfigUtils.java: ## @@ -116,7 +117,7 @@ public static String getBatchSegmentIngestionType(TableCon

Re: [PR] Add Tabled Is Disabled Error [pinot]

2024-10-23 Thread via GitHub
ashishjayamohan commented on PR #14199: URL: https://github.com/apache/pinot/pull/14199#issuecomment-2433993535 Fixed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [I] [Adaptive Server Selector] Extend the HYBRID type to cover query failures [pinot]

2024-10-23 Thread via GitHub
itschrispeck commented on issue #12506: URL: https://github.com/apache/pinot/issues/12506#issuecomment-2434060655 I think this was covered in https://github.com/apache/pinot/pull/14029 (but uses latency penalty instead of query failure count) -- This is an automated message from the Apach

Re: [PR] Prevent task generation when task queue is in STOPPED state [pinot]

2024-10-23 Thread via GitHub
tibrewalpratik17 commented on PR #14257: URL: https://github.com/apache/pinot/pull/14257#issuecomment-2432808069 @rajagopr approved. Re-ran the failed jobs, will merge once they pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Bump hadoop.version from 3.4.0 to 3.4.1 [pinot]

2024-10-23 Thread via GitHub
dependabot[bot] commented on PR #14253: URL: https://github.com/apache/pinot/pull/14253#issuecomment-2433851615 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by

(pinot) branch dependabot/maven/hadoop.version-3.4.1 deleted (was 04eaf2111e)

2024-10-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/hadoop.version-3.4.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was 04eaf2111e Bump hadoop.version from 3.4.0 to 3.4.1 The revisions that were on this

Re: [PR] Bump hadoop.version from 3.4.0 to 3.4.1 [pinot]

2024-10-23 Thread via GitHub
Jackie-Jiang closed pull request #14253: Bump hadoop.version from 3.4.0 to 3.4.1 URL: https://github.com/apache/pinot/pull/14253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Bump hadoop.version from 3.4.0 to 3.4.1 [pinot]

2024-10-23 Thread via GitHub
Jackie-Jiang commented on PR #14253: URL: https://github.com/apache/pinot/pull/14253#issuecomment-2433851573 Done with #14280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

(pinot) branch master updated (ee891a7e3b -> 7879e07b17)

2024-10-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from ee891a7e3b Cleanup setters in IndexLoadingConfig and SegmentGeneratorConfig (#14258) add 7879e07b17 Update hadoop

Re: [PR] Update hadoop & protobuf deps to fix vuls [pinot]

2024-10-23 Thread via GitHub
Jackie-Jiang merged PR #14280: URL: https://github.com/apache/pinot/pull/14280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Add Tabled Is Disabled Error [pinot]

2024-10-23 Thread via GitHub
Jackie-Jiang commented on code in PR #14199: URL: https://github.com/apache/pinot/pull/14199#discussion_r1814016828 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java: ## @@ -638,10 +648,16 @@ protected BrokerResponse ha

Re: [PR] Make IndexLoadingConfig directly read configs from TableConfig and Schema [pinot]

2024-10-23 Thread via GitHub
Jackie-Jiang closed pull request #10355: Make IndexLoadingConfig directly read configs from TableConfig and Schema URL: https://github.com/apache/pinot/pull/10355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Make IndexLoadingConfig directly read configs from TableConfig and Schema [pinot]

2024-10-23 Thread via GitHub
Jackie-Jiang commented on PR #10355: URL: https://github.com/apache/pinot/pull/10355#issuecomment-2433847820 Done with #14258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Cleanup setters in IndexLoadingConfig and SegmentGeneratorConfig [pinot]

2024-10-23 Thread via GitHub
Jackie-Jiang merged PR #14258: URL: https://github.com/apache/pinot/pull/14258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Deprecate _segmentAssignmentStrategy in SegmentsValidationAndRetentionConfig [pinot]

2024-10-23 Thread via GitHub
jadami10 commented on code in PR #11869: URL: https://github.com/apache/pinot/pull/11869#discussion_r1814004022 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/IngestionConfigUtils.java: ## @@ -116,7 +117,7 @@ public static String getBatchSegmentIngestionType(TableConfig

Re: [PR] Deprecate _segmentAssignmentStrategy in SegmentsValidationAndRetentionConfig [pinot]

2024-10-23 Thread via GitHub
Jackie-Jiang commented on code in PR #11869: URL: https://github.com/apache/pinot/pull/11869#discussion_r1813992209 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/IngestionConfigUtils.java: ## @@ -116,7 +117,7 @@ public static String getBatchSegmentIngestionType(TableCon

Re: [PR] Add Tabled Is Disabled Error [pinot]

2024-10-23 Thread via GitHub
ashishjayamohan commented on code in PR #14199: URL: https://github.com/apache/pinot/pull/14199#discussion_r1813843649 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/SparkSegmentMetadataPushIntegrationTest.java: ## @@ -106,13 +106,13 @@ public void s

Re: [PR] Add Tabled Is Disabled Error [pinot]

2024-10-23 Thread via GitHub
Jackie-Jiang commented on code in PR #14199: URL: https://github.com/apache/pinot/pull/14199#discussion_r1813809142 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/SparkSegmentMetadataPushIntegrationTest.java: ## @@ -106,13 +106,13 @@ public void setU

Re: [PR] Add Tabled Is Disabled Error [pinot]

2024-10-23 Thread via GitHub
ashishjayamohan commented on PR #14199: URL: https://github.com/apache/pinot/pull/14199#issuecomment-2433566251 Made those requested changes. Let me know what you think! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Add Tabled Is Disabled Error [pinot]

2024-10-23 Thread via GitHub
ashishjayamohan commented on code in PR #14199: URL: https://github.com/apache/pinot/pull/14199#discussion_r1813771580 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java: ## @@ -620,11 +621,18 @@ protected BrokerResponse

Re: [PR] Add Tabled Is Disabled Error [pinot]

2024-10-23 Thread via GitHub
ashishjayamohan commented on code in PR #14199: URL: https://github.com/apache/pinot/pull/14199#discussion_r1813715893 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/SparkSegmentMetadataPushIntegrationTest.java: ## @@ -106,13 +106,13 @@ public void s

Re: [PR] Retain existing segments for segmentsToCleanUp in startReplaceSegments method [pinot]

2024-10-23 Thread via GitHub
xiangfu0 closed pull request #13953: Retain existing segments for segmentsToCleanUp in startReplaceSegments method URL: https://github.com/apache/pinot/pull/13953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

(pinot) branch dependabot/maven/com.fasterxml.woodstox-woodstox-core-7.1.0 deleted (was 06d80c6cb8)

2024-10-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.fasterxml.woodstox-woodstox-core-7.1.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 06d80c6cb8 Bump com.fasterxml.woodstox:woodstox-core from 7.0.0 t

Re: [PR] Bump testcontainers.version from 1.20.2 to 1.20.3 [pinot]

2024-10-23 Thread via GitHub
Jackie-Jiang merged PR #14281: URL: https://github.com/apache/pinot/pull/14281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Add Tabled Is Disabled Error [pinot]

2024-10-23 Thread via GitHub
Jackie-Jiang commented on code in PR #14199: URL: https://github.com/apache/pinot/pull/14199#discussion_r1813538514 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/SparkSegmentMetadataPushIntegrationTest.java: ## @@ -106,13 +106,13 @@ public void setU

(pinot) branch master updated (a1291a55ae -> 604f767b40)

2024-10-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from a1291a55ae Bump com.fasterxml.woodstox:woodstox-core from 7.0.0 to 7.1.0 (#14283) add 604f767b40 Fix ROUND scalar

(pinot) branch master updated (604f767b40 -> a7b6dd7015)

2024-10-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 604f767b40 Fix ROUND scalar function in the multi-stage query engine (#14284) add a7b6dd7015 Allow using DISTINCT

Re: [PR] Allow using DISTINCTCOUNTTHETASKETCH with filter arguments in the multi-stage query engine [pinot]

2024-10-23 Thread via GitHub
Jackie-Jiang merged PR #14285: URL: https://github.com/apache/pinot/pull/14285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] [Multi-stage] Support lookup join [pinot]

2024-10-23 Thread via GitHub
Jackie-Jiang commented on PR #13966: URL: https://github.com/apache/pinot/pull/13966#issuecomment-2433413427 Documentation: https://docs.pinot.apache.org/users/user-guide-query/multi-stage-query/optimizing-joins#lookup-join -- This is an automated message from the Apache Git Service. To r

Re: [PR] Fix ROUND scalar function in the multi-stage query engine [pinot]

2024-10-23 Thread via GitHub
Jackie-Jiang merged PR #14284: URL: https://github.com/apache/pinot/pull/14284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Bump com.fasterxml.woodstox:woodstox-core from 7.0.0 to 7.1.0 [pinot]

2024-10-23 Thread via GitHub
Jackie-Jiang merged PR #14283: URL: https://github.com/apache/pinot/pull/14283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Bump com.fasterxml.woodstox:woodstox-core from 7.0.0 to 7.1.0 (#14283)

2024-10-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new a1291a55ae Bump com.fasterxml.woodstox:woodstox-c

(pinot) branch dependabot/maven/org.apache.httpcomponents.core5-httpcore5-5.3.1 deleted (was 87b543d230)

2024-10-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/org.apache.httpcomponents.core5-httpcore5-5.3.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was 87b543d230 Bump org.apache.httpcomponents.core5:httpcore5 fr

Re: [PR] Bump org.apache.httpcomponents.core5:httpcore5 from 5.3 to 5.3.1 [pinot]

2024-10-23 Thread via GitHub
Jackie-Jiang merged PR #14282: URL: https://github.com/apache/pinot/pull/14282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (9546c533a1 -> 05383d7bed)

2024-10-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 9546c533a1 Prevent task generation when task queue is in STOPPED state (#14257) add 05383d7bed Bump testcontainer

(pinot) branch master updated: Bump org.apache.httpcomponents.core5:httpcore5 from 5.3 to 5.3.1 (#14282)

2024-10-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 5ac816da71 Bump org.apache.httpcomponents.core5:h

(pinot) branch dependabot/maven/testcontainers.version-1.20.3 deleted (was 2bec5b9798)

2024-10-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/testcontainers.version-1.20.3 in repository https://gitbox.apache.org/repos/asf/pinot.git was 2bec5b9798 Bump testcontainers.version from 1.20.2 to 1.20.3 The revisions tha

Re: [PR] [WIP] Add immtuable CLPForwardIndex and related classes [pinot]

2024-10-23 Thread via GitHub
codecov-commenter commented on PR #14288: URL: https://github.com/apache/pinot/pull/14288#issuecomment-2433284807 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14288?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[I] Make use sortpom plugin https://github.com/Ekryd/sortpom?tab=readme-ov-file to clean and sort the dependencies in pom files [pinot]

2024-10-23 Thread via GitHub
chrajeshbabu opened a new issue, #14287: URL: https://github.com/apache/pinot/issues/14287 As mentioned here https://github.com/apache/pinot/pull/14015#discussion_r1796831201 just raising ticket track cleaning and sorting the dependencies in the pom files. -- This is an automated message

Re: [PR] Bump lucene.version from 9.11.1 to 10.0.0 [pinot]

2024-10-23 Thread via GitHub
hpvd commented on PR #14219: URL: https://github.com/apache/pinot/pull/14219#issuecomment-2432789085 there is also a migration guide from v9.x to v10.x available: https://lucene.apache.org/core/10_0_0/MIGRATE.html -- This is an automated message from the Apache Git Service. To respond t

(pinot) branch master updated: Prevent task generation when task queue is in STOPPED state (#14257)

2024-10-23 Thread manishswaminathan
This is an automated email from the ASF dual-hosted git repository. manishswaminathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 9546c533a1 Prevent task generation whe

Re: [PR] Prevent task generation when task queue is in STOPPED state [pinot]

2024-10-23 Thread via GitHub
swaminathanmanish merged PR #14257: URL: https://github.com/apache/pinot/pull/14257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

(pinot) branch master updated: Test Cases for JMX -> Prom Exporter Regexps (#14155)

2024-10-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 09e88120c4 Test Cases for JMX -> Prom Exporter Re

Re: [PR] Test Cases for JMX -> Prom Exporter Regexps [pinot]

2024-10-23 Thread via GitHub
Jackie-Jiang merged PR #14155: URL: https://github.com/apache/pinot/pull/14155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] [timeseries] Define Time Series ID and Broker Response Name Tag Semantics [pinot]

2024-10-23 Thread via GitHub
codecov-commenter commented on PR #14286: URL: https://github.com/apache/pinot/pull/14286#issuecomment-2432768217 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14286?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Prevent task generation when task queue is in STOPPED state [pinot]

2024-10-23 Thread via GitHub
rajagopr commented on PR #14257: URL: https://github.com/apache/pinot/pull/14257#issuecomment-2432750125 > LGTM otherwise. Thanks for fixing this. Thanks @swaminathanmanish . @tibrewalpratik17 – If you have no more concerns, can you approve as well? -- This is an automated messa

Re: [PR] Allow using DISTINCTCOUNTTHETASKETCH with filter arguments in the multi-stage query engine [pinot]

2024-10-23 Thread via GitHub
codecov-commenter commented on PR #14285: URL: https://github.com/apache/pinot/pull/14285#issuecomment-2432678421 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14285?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Prevent task generation when task queue is in STOPPED state [pinot]

2024-10-23 Thread via GitHub
rajagopr commented on code in PR #14257: URL: https://github.com/apache/pinot/pull/14257#discussion_r1813046891 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java: ## @@ -163,6 +164,9 @@ public Map createTask(String taskType, S

Re: [PR] Prevent task generation when task queue is in STOPPED state [pinot]

2024-10-23 Thread via GitHub
rajagopr commented on code in PR #14257: URL: https://github.com/apache/pinot/pull/14257#discussion_r1813047225 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java: ## @@ -611,9 +613,14 @@ private synchronized List scheduleTask(S

Re: [PR] Prevent task generation when task queue is in STOPPED state [pinot]

2024-10-23 Thread via GitHub
rajagopr commented on code in PR #14257: URL: https://github.com/apache/pinot/pull/14257#discussion_r1813046891 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java: ## @@ -163,6 +164,9 @@ public Map createTask(String taskType, S

[PR] [timeseries] Define Time Series ID and Broker Response Name Tag Semantics [pinot]

2024-10-23 Thread via GitHub
ankitsultana opened a new pull request, #14286: URL: https://github.com/apache/pinot/pull/14286 Defines `TimeSeries#getId()` semantics and semantics for the `__name__` label value in the broker response. There aren't any major changes here; we are just merely defining tl;dr

Re: [PR] [Multi-stage] Support lookup join [pinot]

2024-10-23 Thread via GitHub
gortiz commented on PR #13966: URL: https://github.com/apache/pinot/pull/13966#issuecomment-2432602516 Please remember to document this lookup ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[PR] Allow using DISTINCTCOUNTTHETASKETCH with filter arguments in the multi-stage query engine [pinot]

2024-10-23 Thread via GitHub
yashmayya opened a new pull request, #14285: URL: https://github.com/apache/pinot/pull/14285 - Queries with an aggregation like `DISTINCTCOUNTTHETASKETCH(trip_distance, 'nominalEntries=4096', 'VendorID=1', 'VendorID=2', 'SET_INTERSECT($1, $2)')` currently fail with the following error on th

Re: [PR] Fix ROUND scalar function in the multi-stage query engine [pinot]

2024-10-23 Thread via GitHub
codecov-commenter commented on PR #14284: URL: https://github.com/apache/pinot/pull/14284#issuecomment-2432411152 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14284?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add and use CLPMutableForwardIndexV2 by default to improve ingestion performance and efficiency [pinot]

2024-10-23 Thread via GitHub
jackluo923 commented on PR #14241: URL: https://github.com/apache/pinot/pull/14241#issuecomment-2432303780 > For mutable index, v1 and v2 cannot co-exist. If we are not planning to make it configurable, let's just remove v1 and only keep one mutable index format Sure, I will make the

Re: [PR] Update README [pinot]

2024-10-23 Thread via GitHub
gortiz commented on code in PR #14277: URL: https://github.com/apache/pinot/pull/14277#discussion_r1812557823 ## README.md: ## @@ -88,16 +94,19 @@ SELECT sum(clicks), sum(impressions) FROM AdAnalyticsTable ``` ## Contributing to Pinot -Please refer to the [Contribution Guid

Re: [PR] Speed up dev build. [pinot]

2024-10-23 Thread via GitHub
gortiz commented on code in PR #14210: URL: https://github.com/apache/pinot/pull/14210#discussion_r1812558025 ## README.md: ## @@ -95,10 +95,15 @@ SELECT sum(clicks), sum(impressions) FROM AdAnalyticsTable ## Contributing to Pinot -Normal Pinot builds are done using the `mv

Re: [PR] Speed up dev build. [pinot]

2024-10-23 Thread via GitHub
gortiz commented on code in PR #14210: URL: https://github.com/apache/pinot/pull/14210#discussion_r1812553017 ## README.md: ## @@ -95,10 +95,15 @@ SELECT sum(clicks), sum(impressions) FROM AdAnalyticsTable ## Contributing to Pinot -Normal Pinot builds are done using the `mv

[PR] Bump com.fasterxml.woodstox:woodstox-core from 7.0.0 to 7.1.0 [pinot]

2024-10-23 Thread via GitHub
dependabot[bot] opened a new pull request, #14283: URL: https://github.com/apache/pinot/pull/14283 Bumps [com.fasterxml.woodstox:woodstox-core](https://github.com/FasterXML/woodstox) from 7.0.0 to 7.1.0. Commits https://github.com/FasterXML/woodstox/commit/1fdedb10461f5aeb0b13

(pinot) branch dependabot/maven/com.fasterxml.woodstox-woodstox-core-7.1.0 created (now 06d80c6cb8)

2024-10-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.fasterxml.woodstox-woodstox-core-7.1.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 06d80c6cb8 Bump com.fasterxml.woodstox:woodstox-core from 7.0

(pinot) branch dependabot/maven/org.apache.httpcomponents.core5-httpcore5-5.3.1 created (now 87b543d230)

2024-10-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.httpcomponents.core5-httpcore5-5.3.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at 87b543d230 Bump org.apache.httpcomponents.core5:httpcore

[PR] Bump org.apache.httpcomponents.core5:httpcore5 from 5.3 to 5.3.1 [pinot]

2024-10-23 Thread via GitHub
dependabot[bot] opened a new pull request, #14282: URL: https://github.com/apache/pinot/pull/14282 Bumps [org.apache.httpcomponents.core5:httpcore5](https://github.com/apache/httpcomponents-core) from 5.3 to 5.3.1. Changelog Sourced from https://github.com/apache/httpcomponents-co

[PR] Bump testcontainers.version from 1.20.2 to 1.20.3 [pinot]

2024-10-23 Thread via GitHub
dependabot[bot] opened a new pull request, #14281: URL: https://github.com/apache/pinot/pull/14281 Bumps `testcontainers.version` from 1.20.2 to 1.20.3. Updates `org.testcontainers:testcontainers` from 1.20.2 to 1.20.3 Release notes Sourced from https://github.com/testcontainers/

(pinot) branch dependabot/maven/testcontainers.version-1.20.3 created (now 2bec5b9798)

2024-10-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/testcontainers.version-1.20.3 in repository https://gitbox.apache.org/repos/asf/pinot.git at 2bec5b9798 Bump testcontainers.version from 1.20.2 to 1.20.3 No new revis

Re: [PR] Update hadoop & protobuf deps to fix vuls [pinot]

2024-10-23 Thread via GitHub
codecov-commenter commented on PR #14280: URL: https://github.com/apache/pinot/pull/14280#issuecomment-2431573014 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14280?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Prevent task generation when task queue is in STOPPED state [pinot]

2024-10-23 Thread via GitHub
tibrewalpratik17 commented on code in PR #14257: URL: https://github.com/apache/pinot/pull/14257#discussion_r1812336110 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java: ## @@ -589,6 +601,13 @@ private synchronized List schedu

Re: [PR] Test Cases for JMX -> Prom Exporter Regexps [pinot]

2024-10-23 Thread via GitHub
suddendust commented on code in PR #14155: URL: https://github.com/apache/pinot/pull/14155#discussion_r1812315554 ## pinot-common/src/test/java/org/apache/pinot/common/metrics/prometheus/dropwizard/DropwizardBrokerPrometheusMetricsTest.java: ## @@ -0,0 +1,43 @@ +/** + * Licensed

Re: [PR] Test Cases for JMX -> Prom Exporter Regexps [pinot]

2024-10-23 Thread via GitHub
suddendust commented on code in PR #14155: URL: https://github.com/apache/pinot/pull/14155#discussion_r1812309899 ## pinot-common/src/test/java/org/apache/pinot/common/metrics/BrokerJMXToPromMetricsTest.java: ## @@ -0,0 +1,162 @@ +/** + * Licensed to the Apache Software Foundati

Re: [PR] Test Cases for JMX -> Prom Exporter Regexps [pinot]

2024-10-23 Thread via GitHub
suddendust commented on code in PR #14155: URL: https://github.com/apache/pinot/pull/14155#discussion_r1812266792 ## pinot-common/src/test/java/org/apache/pinot/common/metrics/prometheus/ServerPrometheusMetricsTest.java: ## @@ -0,0 +1,196 @@ +/** + * Licensed to the Apache Softw

[I] Correct loglevel when a table is disabled [pinot]

2024-10-23 Thread via GitHub
piby180 opened a new issue, #14279: URL: https://github.com/apache/pinot/issues/14279 When a table is disabled, we constantly see this error in broker logs. Since the log level is set to ERROR for this, this triggers our alarms. Can we set them to INFO or WARN? ``` 2024/10/23 06:4

Re: [PR] disable-multi-stage-tls [pinot]

2024-10-23 Thread via GitHub
gortiz closed pull request #14275: disable-multi-stage-tls URL: https://github.com/apache/pinot/pull/14275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai