Jackie-Jiang commented on code in PR #14199:
URL: https://github.com/apache/pinot/pull/14199#discussion_r1813538514
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/SparkSegmentMetadataPushIntegrationTest.java:
##########
@@ -106,13 +106,13 @@ public void setUp()
_sparkContext = new SparkContext("local",
SparkSegmentMetadataPushIntegrationTest.class.getName());
}
- @Test
+ @Test(priority = 1)
Review Comment:
Are changes in this file related?
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -620,11 +621,18 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
Map<ServerInstance, Pair<List<String>, List<String>>>
realtimeRoutingTable = null;
List<String> unavailableSegments = new ArrayList<>();
int numPrunedSegmentsTotal = 0;
+ boolean offlineTableDisabled = _routingManager.isTableDisabled(
Review Comment:
Move this check into `if (offlineBrokerRequest != null)`, and use
`offlineTableName`. When table is disabled, no need to compute the routing
table.
Same for real-time table handling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
