yashmayya opened a new pull request, #14285: URL: https://github.com/apache/pinot/pull/14285
- Queries with an aggregation like `DISTINCTCOUNTTHETASKETCH(trip_distance, 'nominalEntries=4096', 'VendorID=1', 'VendorID=2', 'SET_INTERSECT($1, $2)')` currently fail with the following error on the multi-stage query engine: `Invalid number of arguments to function 'DISTINCTCOUNTTHETASKETCH'. Was expecting 1 arguments`. - This is because the Calcite operand type checker for the function was defined as `OperandTypes.family(List.of(SqlTypeFamily.ANY, SqlTypeFamily.CHARACTER)` with the second parameter being optional. However, the aggregation function can actually take any number of arguments greater than 1, see https://github.com/apache/pinot/blob/281478e81951ce804ba890042002080dfbd201de/pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunction.java#L59-L166 - This patch fixes the Calcite operand type checker for the `DISTINCTCOUNTTHETASKETCH` and `DISTINCTCOUNTRAWTHETASKETCH` aggregation functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
