Jackie-Jiang commented on code in PR #14199:
URL: https://github.com/apache/pinot/pull/14199#discussion_r1814016828
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -638,10 +648,16 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
}
}
if (realtimeBrokerRequest != null) {
+ realtimeTableDisabled =
_routingManager.isTableDisabled(realtimeTableName);
// NOTE: Routing table might be null if table is just removed
- RoutingTable routingTable =
_routingManager.getRoutingTable(realtimeBrokerRequest, requestId);
+ RoutingTable routingTable = null;
+ if (!realtimeTableDisabled) {
+ routingTable =
_routingManager.getRoutingTable(realtimeBrokerRequest, requestId);
+ }
if (routingTable != null) {
- unavailableSegments.addAll(routingTable.getUnavailableSegments());
+ if (!realtimeTableDisabled) {
+ unavailableSegments.addAll(routingTable.getUnavailableSegments());
+ }
Review Comment:
This is redundant
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -620,11 +621,20 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
Map<ServerInstance, Pair<List<String>, List<String>>>
realtimeRoutingTable = null;
List<String> unavailableSegments = new ArrayList<>();
int numPrunedSegmentsTotal = 0;
+ boolean offlineTableDisabled = false;
+ boolean realtimeTableDisabled = false;
+ List<ProcessingException> exceptions = new ArrayList<>();
if (offlineBrokerRequest != null) {
+ offlineTableDisabled =
_routingManager.isTableDisabled(offlineTableName);
// NOTE: Routing table might be null if table is just removed
- RoutingTable routingTable =
_routingManager.getRoutingTable(offlineBrokerRequest, requestId);
+ RoutingTable routingTable = null;
+ if (!offlineTableDisabled) {
+ routingTable = _routingManager.getRoutingTable(offlineBrokerRequest,
requestId);
+ }
if (routingTable != null) {
- unavailableSegments.addAll(routingTable.getUnavailableSegments());
+ if (!offlineTableDisabled) {
+ unavailableSegments.addAll(routingTable.getUnavailableSegments());
+ }
Review Comment:
This is redundant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
