rajagopr commented on code in PR #14257:
URL: https://github.com/apache/pinot/pull/14257#discussion_r1813046891
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java:
##########
@@ -163,6 +164,9 @@ public Map<String, String> createTask(String taskType,
String tableName, @Nullab
taskConfigs.getOrDefault(MINION_INSTANCE_TAG_CONFIG,
CommonConstants.Helix.UNTAGGED_MINION_INSTANCE);
_helixTaskResourceManager.ensureTaskQueueExists(taskType);
addTaskTypeMetricsUpdaterIfNeeded(taskType);
+ if (!isTaskSchedulable(taskType, List.of(tableName))) {
Review Comment:
If the task queue does not exist before, the method `ensureTaskQueueExists`
creates the queue and starts the queue. In this case, we do not want to prevent
task creation. For this, `isTaskSchedulable` is kept after the method
`ensureTaskQueueExists`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
