Jackie-Jiang commented on code in PR #11869:
URL: https://github.com/apache/pinot/pull/11869#discussion_r1813992209
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/IngestionConfigUtils.java:
##########
@@ -116,7 +117,7 @@ public static String
getBatchSegmentIngestionType(TableConfig tableConfig) {
if (segmentIngestionType == null) {
segmentIngestionType =
tableConfig.getValidationConfig().getSegmentPushType();
}
- return segmentIngestionType;
+ return (segmentIngestionType == null) ? DEFAULT_SEGMENT_INGESTION_TYPE :
segmentIngestionType;
Review Comment:
I don't remember the history of this change, but this change seems not
related to this PR. Which code path is causing the incident?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
