suddendust commented on code in PR #14155: URL: https://github.com/apache/pinot/pull/14155#discussion_r1812315554
########## pinot-common/src/test/java/org/apache/pinot/common/metrics/prometheus/dropwizard/DropwizardBrokerPrometheusMetricsTest.java: ########## @@ -0,0 +1,43 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.pinot.common.metrics.prometheus.dropwizard; + +import org.apache.pinot.common.metrics.prometheus.BrokerPrometheusMetricsTest; +import org.apache.pinot.plugin.metrics.dropwizard.DropwizardMetricsFactory; +import org.apache.pinot.spi.annotations.metrics.PinotMetricsFactory; +import org.testng.annotations.Test; + + +/** + * Disabling tests as Pinot currently uses Yammer and these tests fail for for {@link DropwizardMetricsFactory} Review Comment: Since we have two metric registries rn, we need tests for both. The only reason why they're disabled is that these tests fail for Dropwizard. So I have kept them explicit that we want these tests but are disabling them because the code for DW seems broken. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
