jadami10 commented on code in PR #11869:
URL: https://github.com/apache/pinot/pull/11869#discussion_r1814004022
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/IngestionConfigUtils.java:
##########
@@ -116,7 +117,7 @@ public static String
getBatchSegmentIngestionType(TableConfig tableConfig) {
if (segmentIngestionType == null) {
segmentIngestionType =
tableConfig.getValidationConfig().getSegmentPushType();
}
- return segmentIngestionType;
+ return (segmentIngestionType == null) ? DEFAULT_SEGMENT_INGESTION_TYPE :
segmentIngestionType;
Review Comment:
Defaulting to `APPEND` causes
https://github.com/apache/pinot/blob/master/pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/name/NormalizedDateSegmentNameGenerator.java#L78
to switch to the `if (_appendPushType)` which renames all segments. Previous,
it went down the other branch first. For refresh tables, this led to duplicated
data.
I'm not sure there's a good default here. It should just throw an exception.
But nothing validates ingestion type or frequency from what I can tell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
