yashmayya commented on PR #14102:
URL: https://github.com/apache/pinot/pull/14102#issuecomment-2380395488
> Does Calcite automatically rewrite BETWEEN into >= and <=?
Yes, that's right.
> Will the change in https://github.com/apache/pinot/pull/13618 prevent this
rewrite?
mghildiy commented on issue #13004:
URL: https://github.com/apache/pinot/issues/13004#issuecomment-2380381980
I am restarting work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
This is an automated email from the ASF dual-hosted git repository.
xbli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new ad1eda52ea fix checks on largest comparison value f
klsince merged PR #14094:
URL: https://github.com/apache/pinot/pull/14094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
raghavyadav01 commented on code in PR #13906:
URL: https://github.com/apache/pinot/pull/13906#discussion_r1777897714
##
pinot-common/src/main/java/org/apache/pinot/common/datablock/BaseDataBlock.java:
##
@@ -338,6 +339,14 @@ public String[] getStringArray(int rowId, int colId) {
codecov-commenter commented on PR #14108:
URL: https://github.com/apache/pinot/pull/14108#issuecomment-2380322116
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/14108?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
raghavyadav01 closed pull request #14093: Add a server level config for segment
server upload to deep store.
URL: https://github.com/apache/pinot/pull/14093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ashishjayamohan opened a new pull request, #14108:
URL: https://github.com/apache/pinot/pull/14108
- Adds default implementation for `RecordReader` interface `next()` function
- Deletes redundant `next` function implementations
- Adds override to scala function redefinition
--
This i
dang-stripe commented on issue #14107:
URL: https://github.com/apache/pinot/issues/14107#issuecomment-2380284285
@priyen-stripe could you include a sample query that was seeing this
behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
dang-stripe opened a new issue, #14107:
URL: https://github.com/apache/pinot/issues/14107
We are testing some multistage queries with joins and adaptive routing
turned on on a table using 3 replicas, 30 servers each. We joined against
another much smaller table 90 replicas, 1 instance each
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new fce17d3d39 Do not allow setting TableConfig in In
Jackie-Jiang commented on code in PR #14098:
URL: https://github.com/apache/pinot/pull/14098#discussion_r1779277390
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##
@@ -135,10 +135,14 @@ public IndexLoadingConfi
Jackie-Jiang merged PR #14098:
URL: https://github.com/apache/pinot/pull/14098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on code in PR #14098:
URL: https://github.com/apache/pinot/pull/14098#discussion_r1779276632
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##
@@ -870,12 +875,6 @@ public Schema getSchema()
klsince commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1779274145
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##
@@ -989,6 +1016,12 @@ protected void doTakeSnapsh
klsince commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1779270018
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java:
##
@@ -192,19 +192,8 @@ public void doRemov
klsince commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1779269113
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##
@@ -435,9 +412,58 @@ public void addSegment(Immut
klsince commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1779269113
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##
@@ -435,9 +412,58 @@ public void addSegment(Immut
klsince commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1779267740
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##
@@ -178,10 +180,13 @@ protected BasePartitionUpse
klsince commented on code in PR #14098:
URL: https://github.com/apache/pinot/pull/14098#discussion_r1779261423
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##
@@ -135,10 +135,14 @@ public IndexLoadingConfig(Ins
Jackie-Jiang commented on issue #14106:
URL: https://github.com/apache/pinot/issues/14106#issuecomment-2380175945
Do not allow setting TableConfig in IndexLoadingConfig after construction:
#14098
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
Jackie-Jiang opened a new issue, #14106:
URL: https://github.com/apache/pinot/issues/14106
`IndexLoadingConfig` should always be initialized by `TableConfig` and
`Schema`, and all the index related config should be extracted from them. Right
now we allow setters to internal fields such as `
codecov-commenter commented on PR #14105:
URL: https://github.com/apache/pinot/pull/14105#issuecomment-2380134700
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/14105?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
codecov-commenter commented on PR #14102:
URL: https://github.com/apache/pinot/pull/14102#issuecomment-2379153445
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/14102?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
jackluo923 opened a new pull request, #14105:
URL: https://github.com/apache/pinot/pull/14105
# WIP description:
`MVFixedBytesRawFwdIndex` currently stores two "length" values for each
document: the first represents the number of elements in the array, and the
second is the byte length o
raghavyadav01 closed pull request #14093: Add a server level config for segment
server upload to deep store.
URL: https://github.com/apache/pinot/pull/14093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
raghavyadav01 commented on code in PR #14093:
URL: https://github.com/apache/pinot/pull/14093#discussion_r1779097594
##
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java:
##
@@ -330,4 +333,10 @@ public PinotConfiguration getAuth
raghavyadav01 commented on code in PR #14093:
URL: https://github.com/apache/pinot/pull/14093#discussion_r1779097365
##
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java:
##
@@ -135,6 +135,9 @@ public class HelixInstanceDataMana
raghavyadav01 commented on code in PR #14093:
URL: https://github.com/apache/pinot/pull/14093#discussion_r1779085297
##
pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/SegmentCommitterFactoryTest.java:
##
@@ -27,16 +27,17 @@
import org.apache.pinot.common.p
tibrewalpratik17 commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1779018465
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java:
##
@@ -192,19 +192,8 @@ public voi
tibrewalpratik17 commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1779007752
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##
@@ -989,6 +1016,12 @@ protected void doT
tibrewalpratik17 commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1779013747
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##
@@ -989,6 +1016,12 @@ protected void doT
dependabot[bot] commented on PR #14090:
URL: https://github.com/apache/pinot/pull/14090#issuecomment-2379020331
Superseded by #14100.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
klsince commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1779011276
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java:
##
@@ -192,19 +192,8 @@ public void doRemov
tibrewalpratik17 commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1779003086
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java:
##
@@ -192,19 +192,8 @@ public voi
tibrewalpratik17 commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1779008707
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##
@@ -178,10 +180,13 @@ protected BasePart
klsince commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1779009051
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##
@@ -989,6 +1016,12 @@ protected void doTakeSnapsh
Jackie-Jiang commented on code in PR #14093:
URL: https://github.com/apache/pinot/pull/14093#discussion_r1779007894
##
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java:
##
@@ -135,6 +135,9 @@ public class HelixInstanceDataManag
klsince commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1779001995
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##
@@ -178,10 +180,13 @@ protected BasePartitionUpse
Jackie-Jiang commented on PR #14102:
URL: https://github.com/apache/pinot/pull/14102#issuecomment-2379820950
Good catch! MV semantic is quite hard to manage, and sometimes very counter
intuitive. Does Calcite automatically rewrite `BETWEEN` into `>=` and `<=`?
Will the change in #13618 prev
tibrewalpratik17 commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1778989315
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##
@@ -435,9 +412,58 @@ public void addSegm
tibrewalpratik17 commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1778988203
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##
@@ -178,10 +180,13 @@ protected BasePart
codecov-commenter commented on PR #14104:
URL: https://github.com/apache/pinot/pull/14104#issuecomment-2379539328
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/14104?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
tibrewalpratik17 commented on issue #13685:
URL: https://github.com/apache/pinot/issues/13685#issuecomment-2379526743
Thanks @dttung2905 @spanasch @shauryachats for adding tests for this!
Closing this issue.
--
This is an automated message from the Apache Git Service.
To respond to the me
This is an automated email from the ASF dual-hosted git repository.
pratik pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 4709954097 Part-4: Remove Unnecessary TimeSeries Materialization +
Minor Cleanups (#14092)
add 3eef3060fa Adding
tibrewalpratik17 closed issue #13685: Add more UTs for AbstractMetrics class
URL: https://github.com/apache/pinot/issues/13685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
tibrewalpratik17 merged PR #14064:
URL: https://github.com/apache/pinot/pull/14064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@p
ankitsultana opened a new pull request, #14104:
URL: https://github.com/apache/pinot/pull/14104
This PR fixes offset handling and the effective filter that's generated, and
also adds some unit-tests.
* Offset handling is fixed by fixing the unit to seconds in the
`LeafTimeSeriesPlanN
abhioncbr commented on issue #14099:
URL: https://github.com/apache/pinot/issues/14099#issuecomment-2379394947
Got it. Thanks for the more context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
yashmayya commented on PR #14102:
URL: https://github.com/apache/pinot/pull/14102#issuecomment-2379383099
The failing integration test is an interesting case:
```
SELECT AVG(AirTime), SUM(OriginStateFips) FROM mytable WHERE DivTailNums
BETWEEN 'N8315C' AND 'N130DL' OR DivAirports I
abhioncbr commented on issue #14099:
URL: https://github.com/apache/pinot/issues/14099#issuecomment-2379030926
I added the module recently, let me look in to it. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
ege-st opened a new pull request, #14103:
URL: https://github.com/apache/pinot/pull/14103
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
ankitsultana commented on issue #14099:
URL: https://github.com/apache/pinot/issues/14099#issuecomment-2379228643
@abhioncbr : Shaurya was planning to pickup the TPCH one, does that work?
@shauryachats
Also, there's an error with pinot-kafka-2.0 also. Just added it to the list.
--
yashmayya opened a new pull request, #14102:
URL: https://github.com/apache/pinot/pull/14102
- Pinot's `BETWEEN` filter predicate currently has a number of issues.
- A query like `SELECT * FROM mytable WHERE intCol BETWEEN 1.5 AND 2.5`
fails because the optimizations in `NumericalFilterOp
This is an automated email from the ASF dual-hosted git repository.
ankitsultana pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 4709954097 Part-4: Remove Unnecessary TimeS
ankitsultana merged PR #14092:
URL: https://github.com/apache/pinot/pull/14092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.fasterxml.jackson-jackson-bom-2.18.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at f968b6a3a8 Bump com.fasterxml.jackson:jackson-bom from 2.17.2 t
dependabot[bot] opened a new pull request, #14100:
URL: https://github.com/apache/pinot/pull/14100
Bumps software.amazon.awssdk:bom from 2.28.6 to 2.28.10.
[
from 2.17.2 to 2.18.0.
Commits
https://github.com/FasterXML/jackson-bom/commit/72365502093e31b
dependabot[bot] closed pull request #14090: Bump software.amazon.awssdk:bom
from 2.28.6 to 2.28.9
URL: https://github.com/apache/pinot/pull/14090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.28.10
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 2c33c8de7b Bump software.amazon.awssdk:bom from 2.28.6 to 2.28.10
No
yashmayya commented on PR #14089:
URL: https://github.com/apache/pinot/pull/14089#issuecomment-2378874424
> Even if we cast after getting the result, it might already lose precision
and give inaccurate result.
Yes, this is a valid point. Also, an expression like `5 / 3 + 1.5` will
re
63 matches
Mail list logo
