klsince commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1779267740
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -178,10 +180,13 @@ protected BasePartitionUpsertMetadataManager(String
tableNameWithType, int parti
}
_serverMetrics = ServerMetrics.get();
_logger = LoggerFactory.getLogger(tableNameWithType + "-" + partitionId +
"-" + getClass().getSimpleName());
- if (_metadataTTL > 0) {
+ if (isTTLEnabled()) {
+ Preconditions.checkState(_enableSnapshot, "Upsert TTL must have snapshot
enabled");
Review Comment:
thanks for the explanation offline, and I adjusted the checks here so that
snapshot is required by metadataTTL only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
