klsince commented on code in PR #14098:
URL: https://github.com/apache/pinot/pull/14098#discussion_r1779261423
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##########
@@ -135,10 +135,14 @@ public IndexLoadingConfig(InstanceDataManagerConfig
instanceDataManagerConfig, T
this(instanceDataManagerConfig, tableConfig, null);
}
+ @VisibleForTesting
public IndexLoadingConfig(TableConfig tableConfig, @Nullable Schema schema) {
extractFromTableConfigAndSchema(tableConfig, schema);
}
+ /**
+ * NOTE: Can be used in production code when we want to load a segment as is
without any modifications.
Review Comment:
would this conflict with the case when user indeed wants to 'remove' all
indexes?
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##########
@@ -870,12 +875,6 @@ public Schema getSchema() {
return _schema;
}
- @VisibleForTesting
- public void setTableConfig(TableConfig tableConfig) {
Review Comment:
👍
I believe logic based on `_dirty = true;` would be fine, as there are a few
other methods setting this flag anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
