yashmayya opened a new pull request, #14102:
URL: https://github.com/apache/pinot/pull/14102

   - Pinot's `BETWEEN` filter predicate currently has a number of issues.
   - A query like `SELECT * FROM mytable WHERE intCol BETWEEN 1.5 AND 2.5` 
fails because the optimizations in `NumericalFilterOptimizer` don't apply to 
`BETWEEN` and there's an error later on when casting the float values to an int 
(via a `String`, which is its own problem in itself, but a matter for separate 
discussion).
   - A query like `SELECT * FROM mytable WHERE col1 BETWEEN col2 AND 100`, 
`SELECT * FROM mytable WHERE col1 BETWEEN 100 AND col2`, or `SELECT * FROM 
mytable WHERE col1 BETWEEN col2 AND col3` fail because Pinot's v1 query engine 
doesn't support filter predicates where the operands (other than the first one) 
are not literals and the query rewrites in `PredicateComparisonRewriter` don't 
apply to `BETWEEN`.
   - One option could be to add support for the `BETWEEN` filter predicate to 
all these optimization and rewrite paths, but since there could be more such 
unknown gaps it seems more straightforward to simply rewrite a `BETWEEN` filter 
predicate to `GREATER_THAN_OR_EQUAL AND LESS_THAN_OR_EQUAL`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to