klsince commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1779269113
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -435,9 +412,58 @@ public void addSegment(ImmutableSegment segment) {
}
}
+ protected boolean isTTLEnabled() {
+ return _metadataTTL > 0 || _deletedKeysTTL > 0;
+ }
+
+ protected void updateTTLWatermark(ImmutableSegment segment) {
Review Comment:
moved the this method close to other watermark related methods
persist/load/deleteWatermark() for more clarify and easy to maintain.
I take `_largestSeenComparisonValue` same as watermark as it's being tracked
in memory, and there is a watermark file to persist it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
