klsince commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1779001995
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -178,10 +180,13 @@ protected BasePartitionUpsertMetadataManager(String
tableNameWithType, int parti
}
_serverMetrics = ServerMetrics.get();
_logger = LoggerFactory.getLogger(tableNameWithType + "-" + partitionId +
"-" + getClass().getSimpleName());
- if (_metadataTTL > 0) {
+ if (isTTLEnabled()) {
+ Preconditions.checkState(_enableSnapshot, "Upsert TTL must have snapshot
enabled");
Review Comment:
I actually tried to make two TTL types more unified, as I see many places
check either one or two, and seems pretty error prone.
as to here, I think the two checks are true for both metadata and deleted
TTL, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
