tibrewalpratik17 commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1779007752
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -989,6 +1016,12 @@ protected void doTakeSnapshot() {
}
}
_updatedSegmentsSinceLastSnapshot.clear();
+ // Persist TTL watermark after taking snapshots if TTL is enabled, so that
segments out of TTL can be loaded with
+ // updated validDocIds bitmaps. If the TTL watermark is persisted first,
segments out of TTL may get loaded with
+ // stale bitmaps or even no bitmap snapshots to use.
+ if (isTTLEnabled()) {
+ persistWatermark(_largestSeenComparisonValue.get());
+ }
Review Comment:
Same this will be persisting watermark for only deletedKeysTTL enabled table
which is not necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
