tibrewalpratik17 commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1778989315
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -435,9 +412,58 @@ public void addSegment(ImmutableSegment segment) {
}
}
+ protected boolean isTTLEnabled() {
+ return _metadataTTL > 0 || _deletedKeysTTL > 0;
+ }
+
+ protected void updateTTLWatermark(ImmutableSegment segment) {
Review Comment:
Actually we are just updating `_largestSeenComparisonValue` here and not
persisting back to watermark. The naming might be confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
